Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated checklist tick icon colour contrast #3698

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Updated checklist tick icon colour contrast #3698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
646bf35
Updated checklist tick icon colour contrast
garethwilliamsdesign Nov 13, 2023
71de48d
Fix icon alignment issue
garethwilliamsdesign Nov 13, 2023
fcce2d8
Reduced gap between icon and list item
garethwilliamsdesign Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/content/checklist_collage_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div>
<ul>
<% checklist.each do |item| %>
<%= tag.li(safe_join([helpers.fa_icon("check"), tag.strong(item)])) %>
<%= tag.li(safe_join([tag.strong(item)])) %>
<% end %>
</ul>
<%= link_to(cta[:text], cta[:link], class: "button") if cta.present? %>
Expand Down
5 changes: 5 additions & 0 deletions app/webpacker/styles/blog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@

li {
background-color: $grey;
margin-bottom: 0;

&:last-child {
margin-bottom: 0;
}

a {
display: block;
Expand Down
32 changes: 16 additions & 16 deletions app/webpacker/styles/components/checklist-collage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,27 @@
ul {
position: relative;
list-style: none;
padding-left: 2rem;
padding-left: 3.5rem;
margin-top: 0;
margin-bottom: 2 * $indent-amount;

li {
position: relative;
margin: $indent-amount 0;

&:not(:first-child) {
margin-top: 3.5em;
}

.fa-check {
margin: 0 0 2em;

&:before {
content: "";
background-image: url("../images/icon-tick.svg");
background-repeat: no-repeat;
background-position: center;
background-size: 40px 40px;
display: block;
width: 30px;
height: 30px;
position: absolute;
color: $white;
left: -2rem;
top: 0;
width: 22px;
height: 20px;
background-color: $yellow;
text-align: center;
border-top: 3px solid $yellow;
margin-left: -3.5rem;
border: solid 4px $black;
top: -5px;
}
}
}
Expand Down
10 changes: 5 additions & 5 deletions app/webpacker/styles/header/extra-navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@

&__link a {
display: inline-block;
padding: .6em 1em;
line-height: 28px;
padding: .75em 1em;
line-height: 24px;

@include mq($until: mobile) {
padding: .6em .8em;
padding: .75em .8em;
}

.icon {
Expand Down Expand Up @@ -79,8 +79,8 @@
a {
background-color: $pink;
margin-left: 1em;
padding: .6em $indent-amount / 2;
line-height: 28px;
padding: .75em;
line-height: 24px;

&:hover {
background-color: $pink-dark;
Expand Down
2 changes: 1 addition & 1 deletion spec/components/content/checklist_collage_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
it { is_expected.to have_css("p", text: "content") }
it { is_expected.to have_css(".images.images-3") }

it "renders the checlist items" do
it "renders the checklist items" do
checklist.each do |item|
is_expected.to have_css("ul li", text: item)
end
Expand Down
Loading