Update unqualified teacher and visa thresholds as variables (Merge into existing Salaries PR) #4035
Conversation
github-actions
bot
added
ruby
| * outer London, you must earn £24,415 | ||
| * London fringe, you must earn £23,200 | ||
| * the rest of England, you must earn £23,200 | ||
| * inner London, you must earn $salaries_skilledworkervisatraineeminfulltime_innerlondon$ |
There was a problem hiding this comment.
Question of whether we need to create a new variable for these given this is the 'non-uk-teachers' page. Do we want to have:
$salaries_skilledworkervisa**unqualified**teacherminfulltime_restofengland$
There was a problem hiding this comment.
@gemmadallmandfe let's chat about this on Monday, I'm not sure what Myles means here
There was a problem hiding this comment.
Move anything salary related to non-uk config file - these relate to salary earnings. Remove these variables from this page and do them in a separate PR. Update this PR title. do non uk visa thresholds as separate PR
There was a problem hiding this comment.
MylesJarvis
changed the title
app/views/content/landing/how-much-do-teachers-get-paid/_content.html.erb
Show resolved
Hide resolved
| * outer London, you must earn £24,415 | ||
| * London fringe, you must earn £23,200 | ||
| * the rest of England, you must earn £23,200 | ||
| * inner London, you must earn $salaries_skilledworkervisatraineeminfulltime_innerlondon$ |
There was a problem hiding this comment.
@gemmadallmandfe let's chat about this on Monday, I'm not sure what Myles means here
…tion) to reflect new variables format
|
Review app deployed to https://get-into-teaching-app-review-4035.test.teacherservices.cloud |
|
|
Closing this PR - will be replaced with three separate PRs |
Trello card
Removing Trello card as it appears to be failing on the pipeline.
Context
Changes proposed in this pull request
Pages with changes:
https://get-into-teaching-app-review-4035.test.teacherservices.cloud/is-teaching-right-for-me/career-progression
https://get-into-teaching-app-review-4035.test.teacherservices.cloud/is-teaching-right-for-me/teacher-pay-and-benefits
https://get-into-teaching-app-review-4035.test.teacherservices.cloud/landing/how-much-do-teachers-get-paid
https://get-into-teaching-app-review-4035.test.teacherservices.cloud/non-uk-teachers/visas-for-non-uk-trainees
https://get-into-teaching-app-review-4035.test.teacherservices.cloud/non-uk-teachers/visas-for-non-uk-teachers
Guidance to review
Review the pages above and merge into the larger Salary PR once ready (I'd recommend doing that after you've checked and verified that specific PR again).
#3977
Pre-election period restrictions