Update subject question on events and mailing list #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
This reverts commit 1f9c517.
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
Sarah-DfE
reviewed
Dec 17, 2024
|
Review app deployed to https://get-into-teaching-app-review-4438.test.teacherservices.cloud |
|
gemmadallmandfe
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Looks good to me from a front-end perspective re the mailing list
I'm unable to test the events funnel as there are no GIT events in the review app - however, the code changes look fine
Happy for this to be merged on Monday once @martyn-w has had a look (including confirming the event funnel changes are OK!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/zuD9ubmC/7041
Context
We ran user research on the mailing list sign up, and changed some of the content on the subject step.
Changes proposed in this pull request
Update the content on the subject pages to reflect findings from research.
Guidance to review