Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subject question on events and mailing list #4438

Merged
merged 7 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/views/mailing_list/steps/_subject.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@
options: { prompt: "Please select" },
label: { tag: 'h1', size: "xl", text: t('helpers.label.mailing_list_steps_subject.preferred_teaching_subject_id', **Value.data) } do
%>
<p>
Select a secondary school subject or select 'primary' even if you're not sure yet. You can change your preferences later.
</p>
<p>Select a secondary school subject or select primary.</p>
<% end %>
4 changes: 2 additions & 2 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ en:
consideration_journey_stage_id:
inclusion: Select how close you are to applying for teacher training
preferred_teaching_subject_id:
inclusion: Select the subject you want to teach
inclusion: Select the subject you're most interested in teaching

callbacks/steps/personal_details:
attributes:
Expand Down Expand Up @@ -809,7 +809,7 @@ en:
mailing_list_steps_teacher_training:
consideration_journey_stage_id: How close are you to applying for teacher training?
mailing_list_steps_subject:
preferred_teaching_subject_id: Which subject do you want to teach?
preferred_teaching_subject_id: Select the subject you're most interested in teaching
mailing_list_steps_postcode:
address_postcode: Your UK postcode (optional)

Expand Down
2 changes: 1 addition & 1 deletion docs/sign-up-journeys.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ graph TD;
authenticate -- On mailing list --> signed_up_already[You've already signed up]
degree_status --> teacher_training[How close are you to applying?]

teacher_training --> subject[Which subject do you want to teach?]
teacher_training --> subject[Select the subject you're most interested in teaching]

subject --> postcode["Your UK postcode (optional)"]

Expand Down
14 changes: 7 additions & 7 deletions spec/features/mailing_list_wizard_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
choose "I'm not sure and finding out more"
click_on "Next step"

expect(page).to have_text "Which subject do you want to teach"
expect(page).to have_text "Select the subject you're most interested in teaching"
select "Maths"
click_on "Next step"

Expand Down Expand Up @@ -73,7 +73,7 @@
choose "I'm not sure and finding out more"
click_on "Next step"

expect(page).to have_text "Which subject do you want to teach"
expect(page).to have_text "Select the subject you're most interested in teaching"
select "Maths"
click_on "Next step"

Expand Down Expand Up @@ -112,7 +112,7 @@
choose "I'm not sure and finding out more"
click_on "Next step"

expect(page).to have_text "Which subject do you want to teach"
expect(page).to have_text "Select the subject you're most interested in teaching"
select "Maths"
click_on "Next step"

Expand Down Expand Up @@ -151,7 +151,7 @@
choose "I'm not sure and finding out more"
click_on "Next step"

expect(page).to have_text "Which subject do you want to teach"
expect(page).to have_text "Select the subject you're most interested in teaching"
select "Maths"
click_on "Next step"

Expand Down Expand Up @@ -203,9 +203,9 @@
)
click_on "Next step"

expect(page).to have_text "Which subject do you want to teach"
expect(page).to have_text "Select the subject you're most interested in teaching"
expect(page).to have_select(
"Which subject do you want to teach?",
"Select the subject you're most interested in teaching",
selected: Crm::TeachingSubject.lookup_by_uuid(response.preferred_teaching_subject_id),
)
click_on "Complete sign up"
Expand Down Expand Up @@ -341,7 +341,7 @@
)
click_on "Next step"

expect(page).to have_text "Which subject do you want to teach"
expect(page).to have_text "Select the subject you're most interested in teaching"
select "Maths"
click_on "Next step"

Expand Down
4 changes: 2 additions & 2 deletions spec/integration/mailing_list_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def sign_up(first_name, last_name, email)
click_label "I’m not sure and finding out more"
click_on "Next step"

expect(page).to have_text "Which subject do you want to teach?"
expect(page).to have_text "Select the subject you're most interested in teaching"
select "Chemistry"
click_on "Next step"

Expand Down Expand Up @@ -84,7 +84,7 @@ def sign_up_if_not_qualified(first_name, last_name, email)
click_label "I’m not sure and finding out more"
click_on "Next step"

expect(page).to have_text("Which subject do you want to teach")
expect(page).to have_text("Select the subject you're most interested in teaching")
select "Maths"
click_on "Next step"

Expand Down
Loading