Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blog tech debt #4455

Merged
merged 18 commits into from
Jan 9, 2025
Merged

Remove blog tech debt #4455

merged 18 commits into from
Jan 9, 2025

Conversation

sarahcrack
Copy link
Collaborator

@sarahcrack sarahcrack commented Dec 30, 2024

Trello card

https://trello.com/c/nhqBpw1I/7148-remove-blog-from-code

Context

We have removed all the blog posts from the site and turned them into inspirational pages within Life as a teacher or quotes on appropriate pages - or just deleted them. We need to clear up all the code relating to blogs including the generation of the main blog page (/blog), styling, etc.

Changes proposed in this pull request

  • removed references to blog in code and relevant tests.
  • renamed folder with notepad image that is still being used in app/views/content/how-to-apply-for-teacher-training.md. New folder name: images/content/application (now houses notepad image). Edited paths so image still appears on page.

Guidance to review

config/routes.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
alt: ""
variants:
- "static/images/content/blog/thumbnails/applying-for-teacher.jpg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmaachesongray Just making sure you are aware that all these images that were being used in the blog are being deleted, in case any are needed for future (unlikely!)

@sarahcrack Can you just check with Emma before merging this PR (presumably not until w/c 6 Jan)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me!

@gemmadallmandfe
Copy link
Contributor

Thanks for doing this @sarahcrack - happy for this to be merged w/c 6 Jan once it has had a tech review!

@sarahcrack sarahcrack marked this pull request as ready for review December 30, 2024 15:57
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

  • I think you can also delete file spec/support/views/content/blog/post_invalid_tag.md
  • And you can remove the "Creating a Blog Post" title (lines 30-32) in file docs/content.md, and then update the numbering

@sarahcrack
Copy link
Collaborator Author

This looks fine.

  • I think you can also delete file spec/support/views/content/blog/post_invalid_tag.md
  • And you can remove the "Creating a Blog Post" title (lines 30-32) in file docs/content.md, and then update the numbering

Thanks for taking a look @martyn-w! I have removed that folder/file. Gemma mentioned that @emmaachesongray has a ticket to update the content guidance so I will leave that for now :)

Copy link

github-actions bot commented Jan 6, 2025

Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@sarahcrack sarahcrack merged commit e5524ff into master Jan 9, 2025
27 checks passed
@sarahcrack sarahcrack deleted the remove-blog-tech-debt branch January 9, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config content Content changes Review ruby Pull requests that update Ruby code Style test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants