-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blog tech debt #4455
Remove blog tech debt #4455
Conversation
…s/blog folder and contents
…ouse notepad image. Edited paths
alt: "" | ||
variants: | ||
- "static/images/content/blog/thumbnails/applying-for-teacher.jpg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmaachesongray Just making sure you are aware that all these images that were being used in the blog are being deleted, in case any are needed for future (unlikely!)
@sarahcrack Can you just check with Emma before merging this PR (presumably not until w/c 6 Jan)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine with me!
Thanks for doing this @sarahcrack - happy for this to be merged w/c 6 Jan once it has had a tech review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine.
- I think you can also delete file
spec/support/views/content/blog/post_invalid_tag.md
- And you can remove the "Creating a Blog Post" title (lines 30-32) in file
docs/content.md
, and then update the numbering
Thanks for taking a look @martyn-w! I have removed that folder/file. Gemma mentioned that @emmaachesongray has a ticket to update the content guidance so I will leave that for now :) |
Review app deployed to https://get-into-teaching-app-review-4455.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Trello card
https://trello.com/c/nhqBpw1I/7148-remove-blog-from-code
Context
We have removed all the blog posts from the site and turned them into inspirational pages within Life as a teacher or quotes on appropriate pages - or just deleted them. We need to clear up all the code relating to blogs including the generation of the main blog page (/blog), styling, etc.
Changes proposed in this pull request
blog
in code and relevant tests.app/views/content/how-to-apply-for-teacher-training.md
. New folder name:images/content/application
(now houses notepad image). Edited paths so image still appears on page.Guidance to review