Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blog tech debt #4455

Merged
merged 18 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49fdf52
removed blog structured data from structured data helper
sarahcrack Dec 20, 2024
fff02fe
deleted views/blog folder and contents
sarahcrack Dec 20, 2024
bc1e99e
removed blog_structured_data from rspec test and deleted views/layout…
sarahcrack Dec 20, 2024
59a1be2
deleted BlogHelper and spec file
sarahcrack Dec 20, 2024
d6baf18
removed BlogController
sarahcrack Dec 20, 2024
fe744b2
removed controllers/blog folder which included tag_controller
sarahcrack Dec 20, 2024
b904892
removed config for blog structured data from prod and dev files
sarahcrack Dec 23, 2024
3ffb366
removed models/pages/blog.rb and spec file
sarahcrack Dec 23, 2024
109c266
removed references to blog in content_pages_spec file
sarahcrack Dec 23, 2024
1b2c44c
removed blog from sitemap controller
sarahcrack Dec 23, 2024
39f08dc
removed blog_posting from structured data spec
sarahcrack Dec 23, 2024
53cbb1e
removed references to blog in routes.rb
sarahcrack Dec 23, 2024
31ae105
removed blog scss file and import to git
sarahcrack Dec 23, 2024
3b378e5
renamed images/content/blog to how-to-apply-for-teacher-training to h…
sarahcrack Dec 23, 2024
99d703f
removed references to blog in images.yml file
sarahcrack Dec 23, 2024
079b17e
re-instated 2 external link redirects to routes.rb as per review comm…
sarahcrack Dec 30, 2024
3972e6d
renamed folder containing notepad image and edited paths
sarahcrack Dec 30, 2024
6e51e2d
removed spec/support/views/content/blog/post_invalid_tag.md and blog …
sarahcrack Jan 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions app/controllers/blog/tag_controller.rb

This file was deleted.

35 changes: 0 additions & 35 deletions app/controllers/blog_controller.rb

This file was deleted.

1 change: 0 additions & 1 deletion app/controllers/sitemap_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ class SitemapController < ApplicationController
# This will keep it consistent with how canonical-rails behaves and ensure search engines are happy.
OTHER_PATHS = %w[
/events
/blog
/events/about-get-into-teaching-events
/mailinglist/signup/name
].freeze
Expand Down
15 changes: 0 additions & 15 deletions app/helpers/blog_helper.rb

This file was deleted.

20 changes: 0 additions & 20 deletions app/helpers/structured_data_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,6 @@ def structured_data(type, data)
end
end

def blog_structured_data(page)
frontmatter = page.frontmatter
author_name = frontmatter[:author]

data = {
headline: frontmatter[:title],
image: frontmatter[:images]&.values&.map { |h| asset_pack_url(h["path"]) },
datePublished: frontmatter[:date],
keywords: frontmatter[:keywords],
author: [
{
"@type": author_name.present? ? "Person" : "Organization",
name: author_name || "Get Into Teaching",
},
],
}.compact

structured_data("BlogPosting", data)
end

def government_organization_structured_data
data = {
"@context": "https://schema.org",
Expand Down
55 changes: 0 additions & 55 deletions app/models/pages/blog.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/views/blog/_date_and_author.html.erb

This file was deleted.

5 changes: 0 additions & 5 deletions app/views/blog/_header.html.erb

This file was deleted.

3 changes: 0 additions & 3 deletions app/views/blog/_highlights.erb

This file was deleted.

17 changes: 0 additions & 17 deletions app/views/blog/_post_preview.html.erb

This file was deleted.

5 changes: 0 additions & 5 deletions app/views/blog/_tag_list.html.erb

This file was deleted.

This file was deleted.

24 changes: 0 additions & 24 deletions app/views/blog/index.html.erb

This file was deleted.

10 changes: 0 additions & 10 deletions app/views/blog/tag/show.html.erb

This file was deleted.

2 changes: 1 addition & 1 deletion app/views/content/how-to-apply-for-teacher-training.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ layout: "layouts/category"
content:
- content/how-to-apply-for-teacher-training/questions
- content/how-to-apply-for-teacher-training/why-teach
image: "static/images/content/blog/notepad.jpg"
image: "static/images/content/application/notepad.jpg"
---
23 changes: 0 additions & 23 deletions app/views/layouts/blog/index.html.erb

This file was deleted.

60 changes: 0 additions & 60 deletions app/views/layouts/blog/post.html.erb

This file was deleted.

Loading
Loading