Routes wizard no results text #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ruby
Sarah-DfE
reviewed
Jan 21, 2025
gemmadallmandfe
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Looks good to me from a front end perspective @spencerldixon
Please revert the steps controller change before merging into the main branch :-D
|
Review app deployed to https://get-into-teaching-app-review-4500.test.teacherservices.cloud |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/wTfk1not/7278-add-journey-for-routes-wizard-users-when-there-are-no-results
Context
We want to create a fallback journey if a combination of answers does not result in any routes results
Changes proposed in this pull request
Guidance to review