Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes wizard no results text #4500

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Routes wizard no results text #4500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07ebabe
Added no results text
spencerldixon Jan 21, 2025
9a279b5
updating link to help and support instead of TTA
Sarah-DfE Jan 21, 2025
b2fa43d
Remove results override
spencerldixon Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/routes_into_teaching/steps_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def completed
end

@results = RoutesIntoTeaching::Routes.recommended(session[:routes_into_teaching])
@results = [] # TODO - remove before deploy
end

private
Expand Down
19 changes: 10 additions & 9 deletions app/views/routes_into_teaching/steps/completed.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@
<div class="row inset">
<div class="col col-845">
<h2 class="heading--box-blue">Your options</h2>
<p>Based on your answers, you may be eligible for the following teacher training options:</p>
</div>
</div>

<div class="row inset">
<div class="col col-845">
<% @results.each do |result| %>
<div class="col-space-s">
<%= render Content::ResultsBoxComponent.new(
<% if @results.any? %>
<p>Based on your answers, you may be eligible for the following teacher training options:</p>

<% @results.each do |result| %>
<div class="col-space-s">
<%= render Content::ResultsBoxComponent.new(
heading: result["title"],
fee: result["course_fee"],
course_length: result["course_length"],
Expand All @@ -46,7 +44,10 @@
link_text: result["cta_text"],
link_target: result["cta_link"],
) %>
</div>
</div>
<% end %>
<% else %>
<p>There are no teacher training routes that match your current circumstances. To find out more about routes into teaching, <%= link_to "speak to one of our teacher training advisers", "/teacher-training-advisers" %>.</p>
Sarah-DfE marked this conversation as resolved.
Show resolved Hide resolved
Sarah-DfE marked this conversation as resolved.
Show resolved Hide resolved
<% end %>
</div>
</div>
Expand Down
Loading