🎨 Standardize naming for atlases used in RBC #1823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to FCP-INDI/C-PAC_templates#4, #1641, & #1808 by @shnizzedy
With #1825, this PR is fully included in #1831, so if all three are approved, we can just merge #1831 and get all three without having to do any merge conflict resolution.
Description
For the atlases used in
rbc-options
,CPAC/resources/templates/BIDS_identifiers.tsv
f'atlas-{strip_extension(basename(atlas_filename))}'
withf'atlas-{atlasname}'
orf'atlas-{atlasname}_desc-{atlasdesc}'
in derivative filenames(for example,
Technical details
This still allows duplicate
desc
entities and-
s in entity values; those will be addressed in separate PRsScreenshots
Checklist
Update index.md
).develop
branch of the repository.Developer Certificate of Origin
Developer Certificate of Origin