SDKS-3221 uses English locale when generating certificate for Application Pin #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyanthanperiyasamy
previously approved these changes
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #418 +/- ##
=============================================
+ Coverage 67.91% 67.95% +0.04%
- Complexity 1664 1666 +2
=============================================
Files 243 243
Lines 7658 7659 +1
Branches 823 823
=============================================
+ Hits 5201 5205 +4
+ Misses 2078 2077 -1
+ Partials 379 377 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
forgerock-core/src/main/java/org/forgerock/android/auth/AppPinAuthenticator.kt
Show resolved
Hide resolved
rodrigoareis
previously requested changes
May 23, 2024
spetrov
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
JIRA Ticket
SDKS-3221
Description
SDKS-3221 uses English locale when generating certificate for Application Pin