Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3221 uses English locale when generating certificate for Application Pin #418

Merged
merged 1 commit into from
May 29, 2024
Merged

SDKS-3221 uses English locale when generating certificate for Application Pin #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [4.4.2]
#### Fixed
- SDKS-3073 Resolve commons-io-2.6.jar and bcprov-jdk15on-1.68.jar vulnerability warning [SDKS-3073]
- Resolve commons-io-2.6.jar and bcprov-jdk15on-1.68.jar vulnerability warning [SDKS-3073]
- Use English locale when generating certificate for Application Pin [SDKS-3221]

## [4.4.1]
#### Fixed
Expand Down
3 changes: 2 additions & 1 deletion forgerock-core/src/main/java/org/forgerock/android/auth/AppPinAuthenticator.kt
View file
Open in desktop
witrisna marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022 ForgeRock. All rights reserved.
* Copyright (c) 2022 - 2024 ForgeRock. All rights reserved.
*
* This software may be modified and distributed under the terms
* of the MIT license. See the LICENSE file for details.
Expand Down Expand Up @@ -111,6 +111,7 @@ class AppPinAuthenticator(private val cryptoKey: CryptoKey,
BigInteger.valueOf(System.currentTimeMillis()),
validityBeginDate,
validityBeginDate,
Locale.ENGLISH,
owner,
SubjectPublicKeyInfo.getInstance(keyPair.public.encoded))
return JcaX509CertificateConverter().getCertificate(builder.build(sigGen))
Expand Down
Loading