-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub actions build (WIP) #77
base: master
Are you sure you want to change the base?
Conversation
I just opened pull request #82 that fixes the build breakage caused because I added a variable Screen::scrollWheelEnabled but forgot to test that the server configuration builds when I added that variable. Now Ubuntu 20.04 should be able to build correctly with If you look closely at the include lines in the Windows msys2 build, they seem to be two paths concatenated together for some reason. The include arguments I'm talking about are If this gets merged, it can be used as a fallback if Travis-CI goes down and Travis-CI can still build even if GitHub Actions has a problem in the future. If GitHub itself goes down, well, that could be a problem since the SourceForge mirror hasn't been updated in quite some time. The Ubuntu 22.04 build is failing because the file |
This fixes the packaging error during the Ubuntu 22.04 CI build for PR Globulation2#77.
This fixes the packaging error during the Ubuntu 22.04 CI build for PR Globulation2#77.
This fixes the packaging error during the Ubuntu 22.04 CI build for PR #77.
@Quipyowert2 I rebased my changes on the latest master, and applied your suggestion for the Windows build. The issue on Windows side still remains the same, and the error on Ubuntu side is beyond my understanding! (Link to action run) |
Sorry, it's my fault the PR failing to build in Ubuntu 20.04 and 22.04. In PR #78, I changed the The build failure in the Windows build seems to be an include path problem. I am not sure why SCons smashes the paths together like that. The include argument In the Windows section of the YAML file, if you instead put Note: With SCons 4.4.1, you might have to apply either of the following patches to Glob2 and SCons to build on Windows: SConstruct-changes-for-msys2.patch, Patch for SCons itself. @stephanemagnenat Do you know how to fix the Windows build in this pull request? |
In PR Globulation2#96, "snprintf & friends", I changed an ifdef near the line that was moved in patch Globulation2#3. That fixed an error with Visual Studio 2015 and later, but caused that patch to fail to apply in GitHub Actions PR Globulation2#77.
In PR Globulation2#96, "snprintf & friends", I changed an ifdef near the line that was moved in patch Globulation2#3. That fixed an error with Visual Studio 2015 and later, but caused the patch to fail to apply in GitHub Actions PR Globulation2#77.
In PR Globulation2#96, "snprintf & friends", I changed an #ifdef near the line that was moved in patch Globulation2#3. That fixed an error with Visual Studio 2015 and later, but caused the patch to fail to apply in GitHub Actions PR Globulation2#77.
In PR Globulation2#96, "snprintf & friends", I changed an #ifdef near the line that was moved in patch Globulation2#3. That change fixes an error with Visual Studio 2015 and later, but caused the patch to fail to apply in GitHub Actions PR Globulation2#77.
In PR Globulation2#78, "snprintf & friends", I changed an #ifdef near the line that was moved in patch Globulation2#3. That change fixes an error with Visual Studio 2015 and later, but caused the patch to fail to apply in GitHub Actions PR Globulation2#77.
This works partially:
For Ubuntu, it builds, but packaging does not work.
For Windows, I got stuck getting a build. I couldn't figure out how I should get the libraries for cross-compiling on Ubuntu. So I tried building on msys2 on Windows, and scons cannot find anything. I think it is looking for things in the wrong places. And for some reason, the behavior on GitHub actions is different from the behavior on my local machine.
(I did this some time ago. In fact, I think I've forgotten what I was doing... And sorry for the commit messages! I think we should squash them, so I didn't touch anything.)