Rename make-pin

[tjknoth]

Will merge once the jitx-client updates are released.

[linear]

PROD-361 Syntax Reforms - change `make-pin` -> `make-port`

[tjknoth]

jitx-client PR is merged; will merge this once release goes out

[callendorph]

With 3.18.0 released - can we please get this merged ?

[tjknoth]

With 3.18.0 released - can we please get this merged ?

The tests still aren't passing in CI -- is that supposed to be using an up-to-date jitx-client? should I just force merge?

[callendorph]

jitx-client-1  | src/bundles/comms.stanza:40.19: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:41.19: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:131.16: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:132.17: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:133.17: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:207.15: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:273.17: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:274.17: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:275.17: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:276.17: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:
jitx-client-1  |   make-port: (Symbol, PortType) -> Pin in package 'jitx/commands'
jitx-client-1  | 
jitx-client-1  | src/bundles/comms.stanza:277.17: No appropriate function 'make-port' for argument types (Symbol). Possibilities are:

Seems like we are using make-port wrong - no ?

[tjknoth]

That function does exist (in commands.stanza)

public defn make-port (name:Symbol) :
  make-port(JITX-CLIENT, false, name, SinglePin())

It's been there for like a month

[callendorph]

🤷

[tjknoth]

Hm apparently it is not in the version of jitx-client (tag 3.18.0-develop.29) that's running the tests

[tjknoth]

The correct code does seem to be in the release, however

[callendorph]

Ya - the docker image might not have the updated code ?

[callendorph]

Thanks Tristan!