Add Keepout Generators for SMT Components #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function ends up being useful in multiple places and so I will make it part of the public interface to `VirtualLP`
I'm going to use this for creating the keepouts underneath components, particularly for SMT chips but also for things like keepouts in QFN packages.
bhusang
reviewed
Sep 26, 2024
| public defn ensure-not-empty! (field:String, value:Collection) : | ||
| if count(value) == 0: | ||
| throw $ ValueError("Expected Non-Empty Collection - Found: %_" % [value]) |
There was a problem hiding this comment.
What does the argument field:String do here?
There was a problem hiding this comment.
This is the interface for the ensure => FUNC members of a defstruct field. I believe it gets used by the defstruct macro to tell the user which field of the defstruct had this fault case.
bhusang
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a mechanism for customizing the keep out generators for components, specifically SMT components:
Notice that this keepout currently works for planes but it is not yet working for traces.
Goal will be to expand this to support QFNs and other packages where we need to provide keepout functionality.