Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enum variant docs to jsl #188

Merged
merged 1 commit into from
Oct 4, 2024
Merged

add enum variant docs to jsl #188

merged 1 commit into from
Oct 4, 2024

Conversation

plasmajitx
Copy link
Contributor

No description provided.

@bhusang
Copy link
Contributor

bhusang commented Oct 4, 2024

@plasmajitx This is great, but how does one know that all @members of the various objects in JSL are listed? Do you have an automated method for discovery?

@plasmajitx
Copy link
Contributor Author

docgen prints a warning when it thinks there's an enum variant that doesn't have an @member. so I had a big list of warnings to work from.

it also relies on having an @member internally to know that the definition is a true defenum and to resolve links to the variants, which is why I wanted to make sure we get all these in.

@plasmajitx plasmajitx merged commit 5375f31 into main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants