Updates to the non-plated hole and support for changes to mechanical/MountingHoles
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhusang
approved these changes
Nov 8, 2024
bhusang
reviewed
Nov 25, 2024
src/landpatterns/VirtualLP.stanza
Outdated
| @@ -376,6 +376,30 @@ public defn get-layers (vp:VirtualLP, offset:Pose = loc(0.0, 0.0)) -> Tuple<Laye | |||
| get-layers(child, offset * pose(child)) | |||
| to-tuple $ cat(local-art, kid-art) | |||
|
|
|||
| doc: \<DOC> | |||
| Retrieve Geoemtry for all including pads | |||
There was a problem hiding this comment.
Retrieve Geoemtry for all including pads
->
Retrieve Geometry for all including pads
bhusang
reviewed
Nov 25, 2024
src/landpatterns/numbering.stanza
Outdated
| Null Numbering Object | ||
|
|
||
| This is a default object for creating packages that don't require | ||
| any pad numbering. These landpatterns may not contain any pads to |
There was a problem hiding this comment.
Is this may not or should not?
There was a problem hiding this comment.
This doesn't prevent composition of landpatterns or manually defining, for example, a mechanical hole pad outside of these constructs.
There was a problem hiding this comment.
Cool, then maybe we change the language to something like?
"These landpatterns do not need to contain any pads to number."
bhusang
approved these changes
Nov 25, 2024
This supports the cases where we don't need these types in a landpattern generator.
This adds some additional geometry implementations to suplement the JITX runtime
The Polygon and PolygonWithArcs have no `expand` operator in the JITX runtime. I've just forced this to return the same shapes for now so that I can have this functionality work. It now prints an error message instead of just `FATAL`
The current platform can't support non-plated holes via the `pcb-pad` definition. I've added: 1. Generators for creating non-plated hole statements 2. Landpatterns for non-plated holes. I've left the current `npth-pad` function in place and marked it with a deprecation warning. We will remove in a future iteration.
callendorph
force-pushed
the
cja/fix_npth
branch
from
4c3b4ea to
531c869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many changes here - most of them are going to support better handling of mounting holes.