-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the non-plated hole and support for changes to mechanical/MountingHoles
#209
Merged
+517
−111
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
426d931
[Refactor] Format updating and simplification
callendorph ec13408
Added new NullNumbering and NullPadPlanner
callendorph 9bf7478
Develop the `expand-union` further and add `convex-hull`
callendorph 053349f
Updated courtyard origin to handle any shape
callendorph 775af67
Added silkscreen outline for cylinder bodies
callendorph 786c4f3
Added VirtualLP to get all shapes recursively including pads
callendorph 7cf724e
Added handling for Polygon and PolygonWithArcs in `expand-union`
callendorph c023f1b
[Bugfix] Fixed the non-plated through hole implementations
callendorph 358ae22
Simplified default arg values for `pth-pad`
callendorph 06cc9ea
Bugfixes and updates to docs for the soldermask in pads
callendorph 531c869
Added a non-plated hole helper function for the Virtual LP scene graph
callendorph 9200720
Fix doc issues from the PR comments
callendorph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added new NullNumbering and NullPadPlanner
This supports the cases where we don't need these types in a landpattern generator.
commit ec1340865c91901e1f6f151397e6215600cc723f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this
may not
orshould not
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't prevent composition of landpatterns or manually defining, for example, a mechanical hole pad outside of these constructs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, then maybe we change the language to something like?
"These landpatterns do not need to contain any pads to number."