fix: rotation card dimensions #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L-fix-rotation-card-dimensions
storyworks
added
priority: 2day
type: fix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
GeronimoJohn
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 3rd party library we were using to fix dynamic viewport heights on Safari was bugging out in Chrome when devices were being rotated. There's no official fix yet but comments have recommended using a previous version of the library.
mvasin/react-div-100vh#76
- Link to Basecamp Todo
How should this PR be QA Tested?
Please describe the QA tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist