Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xy_goal_toleranceyaw_goal_toleranceを動的に変更できるようにしたい #23

Open
Alpaca-zip opened this issue Nov 23, 2023 · 0 comments
Assignees

Comments

@Alpaca-zip
Copy link
Collaborator

Alpaca-zip commented Nov 23, 2023

概要
waypoint_navigationとnavigation2でゴール判定が違うためコードの保守性が悪く、バグ*1を踏んでいそう。

改善案
navigation2ではゴール判定を動的に変えられるようになっているので(以下参照)、waypoint_navigation側でxy_goal_toleranceおよびyaw_goal_toleranceをsetしてnav_status_ == rclcpp_action::ResultCode::SUCCEEDEDのみで判定するようにできそう。

https://github.com/ros-planning/navigation2/blob/4bc3e8a534005e983ee7a49a09ec00aeb9820661/nav2_controller/plugins/simple_goal_checker.cpp#L144-L166

具体的には、xy_goal_toleranceにradを、yaw_goal_toleranceには $\pi$ とか $2\pi$ を設定して、stop が true のときはmin_yaw_errの値を設定できるようにしたい。

@Alpaca-zip Alpaca-zip self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant