Standardizing system names #560
Merged
+475
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfhaque Can you please figure out what I missed in the dry runs, and review? I would like to merge this to make our system naming more uniform. |
rfhaque
reviewed
Jan 24, 2025
.github/workflows/run.yml
Outdated
Comment on lines
761
to
841
| dynamicdryrunexperiments: | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout Benchpark | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | ||
|
|
||
| - name: Add needed Python libs | ||
| run: | | ||
| pip install -r ./requirements.txt | ||
|
|
||
| - name: Dynamic saxpy/openmp llnl-cluster cluster=ruby compiler=intel | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: openmp | ||
| benchmark_spec: saxpy+openmp | ||
| system_name: ruby | ||
| system_spec: llnl-cluster cluster=ruby compiler=intel | ||
|
|
||
| - name: Dynamic saxpy/openmp llnl-cluster cluster=dane | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: openmp | ||
| benchmark_spec: saxpy+openmp | ||
| system_name: dane | ||
| system_spec: llnl-cluster cluster=dane | ||
|
|
||
| - name: Dynamic saxpy/openmp llnl-cluster cluster=magma | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: openmp | ||
| benchmark_spec: saxpy+openmp | ||
| system_name: magma | ||
| system_spec: llnl-cluster cluster=magma | ||
|
|
||
| - name: Dynamic saxpy/openmp aws-pcluster instance_type=hpc6a.48xlarge | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: openmp | ||
| benchmark_spec: saxpy+openmp | ||
| system_name: aws | ||
| system_spec: aws-pcluster instance_type=hpc6a.48xlarge | ||
|
|
||
| - name: Dynamic saxpy/openmp venado lanl-venado cuda=12.5 compiler=cce +gtl | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: openmp | ||
| benchmark_spec: saxpy+openmp | ||
| system_name: venado | ||
| system_spec: lanl-venado cuda=12.5 compiler=cce +gtl | ||
|
|
||
| - name: Dynamic saxpy/cuda lassen llnl-sierra cuda=10-1-243 compiler=xl | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: cuda | ||
| benchmark_spec: saxpy+cuda | ||
| system_name: lassen | ||
| system_spec: llnl-sierra cuda=10-1-243 compiler=xl | ||
|
|
||
| - name: Dynamic saxpy/cuda venado lanl-venado cuda=12.5 compiler=cce +gtl | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: cuda | ||
| benchmark_spec: saxpy+cuda | ||
| system_name: venado | ||
| system_spec: lanl-venado cuda=12.5 compiler=cce +gtl | ||
|
|
||
| - name: Dynamic saxpy/rocm tioga llnl-elcapitan rocm=5.5.1 compiler=cce ~gtl | ||
| uses: ./.github/actions/dynamic-dry-run | ||
| with: | ||
| benchmark_name: saxpy | ||
| benchmark_mode: rocm | ||
| benchmark_spec: saxpy+rocm | ||
| system_name: tioga | ||
| system_spec: llnl-elcapitan rocm=5.5.1 compiler=cce ~gtl |
There was a problem hiding this comment.
@pearce8 Adding a reusable action step to run experiments. We can convert all other experiments to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making system names follow site-system name conventions.
Dependencies: none.
Fixes issue(s): none.
Type of Change
Checklist:
If adding/modifying a system:
system.pyfile.github/workflowsIf adding/modifying a benchpark:
application.pyand (maybe)package.pyunder a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.pyunder existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflowsand.gitlab/ciunit tests (if needed)