Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing system names #560

Merged
merged 22 commits into from
Jan 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/actions/dynamic-dry-run/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: Dynamic dry run template

inputs:
benchmark_name:
required: true
type: string
benchmark_mode:
required: true
type: string
benchmark_spec:
required: true
type: string
system_name:
required: true
type: string
system_spec:
required: true
type: string

runs:
using: "composite"
steps:
- name: "${{ inputs.benchmark_name }}/${{ inputs.benchmark_mode }} ${{ inputs.system_name }} ${{ inputs.system_spec }}"
shell: bash
run: |
timestamp=$(date +%s)
bn="${{ inputs.benchmark_name }}"
bm="${{ inputs.benchmark_mode }}"
benchmark="$bn-$bm-$timestamp"
sn="${{ inputs.system_name }}"
system="$sn-$timestamp"
./bin/benchpark system init --dest=$system ${{ inputs.system_spec }}
system_id=$(./bin/benchpark system id ./$system)
./bin/benchpark experiment init --dest=$benchmark ${{ inputs.benchmark_spec }}
./bin/benchpark setup ./$benchmark ./$system workspace/
. workspace/setup.sh
ramble \
--workspace-dir "workspace/$benchmark/$system_id/workspace" \
--disable-progress-bar \
--disable-logger \
workspace setup --dry-run
884 changes: 429 additions & 455 deletions .github/workflows/run.yml

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from benchpark.system import System


class Genericx86(System):
class GenericX86(System):
"""This is the generic system class for an x86 system, gcc compiler, mpi.
It can be easily copied and modified to model other systems."""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ compilers:
prepend_path:
PATH: /opt/FJSVxtclanga/tcsds-1.2.38/bin
LD_LIBRARY_PATH: /opt/FJSVxtclanga/tcsds-1.2.38/lib64
extra_rpaths: []
extra_rpaths: []
6 changes: 3 additions & 3 deletions systems/fugaku/system.py → systems/riken-fugaku/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from benchpark.system import System


class Fugaku(System):
class RikenFugaku(System):

variant(
"compiler",
Expand All @@ -34,15 +34,15 @@ def generate_description(self, output_dir):
f.write(self.sw_description())

def external_pkg_configs(self):
externals = Fugaku.resource_location / "externals"
externals = RikenFugaku.resource_location / "externals"

# Doesn't look like we need to switch MPI based on compiler from old definition, verify this
selections = [externals / "base" / "00-packages.yaml"]

return selections

def compiler_configs(self):
compilers = Fugaku.resource_location / "compilers"
compilers = RikenFugaku.resource_location / "compilers"

compiler = self.spec.variants["compiler"][0]

Expand Down