Convert Add / Remove Host form for Host Aggregate #8078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelsHyrule
force-pushed
the
add_remove_host_aggregate
branch
3 times, most recently
from
8db326e to
776ec85
Compare
GilbertCherrie
approved these changes
Feb 8, 2022
MelsHyrule
force-pushed
the
add_remove_host_aggregate
branch
9 times, most recently
from
9a69270 to
de03be7
Compare
There was a problem hiding this comment.
@MelsHyrule Looks good to me, only suggestion is if possible add test cases for the remove host aggregate form as well.
MelsHyrule
force-pushed
the
add_remove_host_aggregate
branch
3 times, most recently
from
d84006d to
f8fa678
Compare
MelsHyrule
changed the title
MelsHyrule
force-pushed
the
add_remove_host_aggregate
branch
from
f8fa678 to
2fc0f1b
Compare
MelsHyrule
force-pushed
the
add_remove_host_aggregate
branch
from
3f15ae2 to
900c58c
Compare
|
Checked commit MelsHyrule@900c58c with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint app/views/host_aggregate/add_host_select.html.haml
app/views/host_aggregate/remove_host_select.html.haml
|
kavyanekkalapu
changed the title
kavyanekkalapu
approved these changes
Feb 16, 2022
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/manageiq-api#1124
Fixes 6868 and 6869
BEFORE
AFTER