Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace angular code #7603

Open
10 tasks
himdel opened this issue Jan 26, 2021 · 11 comments
Open
10 tasks

Replace angular code #7603

himdel opened this issue Jan 26, 2021 · 11 comments

Comments

@himdel
Copy link
Contributor

himdel commented Jan 26, 2021

We do have a lot of angular.js 1.x code that should eventually be rewritten to react or DDF, as per version-support-status, it ends LTS in Dec 2021.

We don't use angular router, or ng-app, so any angular code needs miq_bootstrap to render (which uses angular.bootstrap to run angular).

This happens from:

  • error modal - a self contained component that pops up a modal on unexpected 4** or 5** HTTP responses, shoud be trivial to rewrite

Views - forms (find issues)

Views - dialog user/editor:

Views - unsorted:

We also have multiple angular plugins - see #6452 (comment)
And components in ui-components - issue already exists: #6716

Previous Releases:

@Fryguy
Copy link
Member

Fryguy commented Jan 26, 2021

Updated to checkboxes 😄

@Fryguy
Copy link
Member

Fryguy commented Jan 26, 2021

@himdel Can you reorganize the list so that provider dashboards are grouped together? I'm wondering if we focused on a provider dashboard react component if that would knock off a huge chunk of the list.

@himdel
Copy link
Contributor Author

himdel commented Jan 27, 2021

Resorted and split into forms, dashboards, topologies, a few trivial uses ..and the rest :).

@himdel
Copy link
Contributor Author

himdel commented Jan 27, 2021

Another nontrivial part that stands out is generic object + generic object definition - those screens are fully angular (and have additional issues) - might be another candidate for dropping?

@himdel
Copy link
Contributor Author

himdel commented Jan 27, 2021

Hopefully we have 0 class-based directives, as those are impossible to distinguish from css classes.

And as for attribute directives, I'm seeing..

  • pf-form-group with pf-label - can be replaced by a class and a label element
  • pf-select - can be replaced by our miq-select fork (from ui-components)

@Fryguy
Copy link
Member

Fryguy commented Jan 28, 2021

Another nontrivial part that stands out is generic object + generic object definition - those screens are fully angular (and have additional issues) - might be another candidate for dropping?

I don't think we can drop that...looks like we'll have to covert to react.

@chessbyte
Copy link
Member

Amazing that this list is down to ~20 items! Nice work everyone!

@GilbertCherrie
Copy link
Member

Updated the issue to move all completed points from this master issue to the new Petrosian and Quinteros issues.

@miq-bot
Copy link
Member

miq-bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

@miq-bot miq-bot added the stale label Apr 22, 2024
@Fryguy Fryguy added this to Roadmap Jun 12, 2024
@Fryguy Fryguy moved this to In progress in Roadmap Jun 12, 2024
@miq-bot
Copy link
Member

miq-bot commented Sep 16, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Dec 23, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

9 participants