-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace angular code #7603
Comments
Updated to checkboxes 😄 |
@himdel Can you reorganize the list so that provider dashboards are grouped together? I'm wondering if we focused on a provider dashboard react component if that would knock off a huge chunk of the list. |
Resorted and split into forms, dashboards, topologies, a few trivial uses ..and the rest :). |
Another nontrivial part that stands out is generic object + generic object definition - those screens are fully angular (and have additional issues) - might be another candidate for dropping? |
Hopefully we have 0 class-based directives, as those are impossible to distinguish from css classes. And as for attribute directives, I'm seeing..
|
I don't think we can drop that...looks like we'll have to covert to react. |
Amazing that this list is down to ~20 items! Nice work everyone! |
Updated the issue to move all completed points from this master issue to the new Petrosian and Quinteros issues. |
This issue has been automatically marked as stale because it has not been updated for at least 3 months. If you can still reproduce this issue on the current release or on |
This issue has been automatically marked as stale because it has not been updated for at least 3 months. If you can still reproduce this issue on the current release or on |
1 similar comment
This issue has been automatically marked as stale because it has not been updated for at least 3 months. If you can still reproduce this issue on the current release or on |
We do have a lot of angular.js 1.x code that should eventually be rewritten to react or DDF, as per version-support-status, it ends LTS in Dec 2021.
We don't use angular router, or
ng-app
, so any angular code needsmiq_bootstrap
to render (which usesangular.bootstrap
to run angular).This happens from:
Views - forms (find issues)
miq_ae_class/
:_angular_method_form.html.haml
-(Automation/Automate/Explorer/Datastore -> Select a Domain -> Select a Namespace -> Select a Class -> Add a New Method) - (Expression Editor by @amalvijayan03 - [WIP]Expression editor conversion from HAML to React #8944)_embedded_methods.html.haml
- (Same Form as Above but When Adding a New Method, Set Type toInline
)ops/
:_settings_replication_tab.html.haml
- (Settings -> Application Settings -> Settings -> Select Region -> Replication)Views - dialog user/editor:
miq_ae_customization/
:editor.html.haml
- dialog editor (Automation/Automate/Customization/Service Dialogs -> Add a new Dialog)shared/dialogs/
:_reconfigure_dialog.html.haml
- dialog user in reconfigure mode [WIP] Convert Service Reconfigure Form Page to React #8951_dialog_user.html.haml
- dialog user proper Order Service Form conversion from Angular to React #8911Views - unsorted:
layouts/listnav/
:_explorer.html.haml
_generic_object_definition_show_list_with_treeview.html.haml
- generic objects show_list navigation tree (Automation/Automate/Generic Objects)We also have multiple angular plugins - see #6452 (comment)
And components in ui-components - issue already exists: #6716
Previous Releases:
The text was updated successfully, but these errors were encountered: