Log Collection Form conversion from Angular to React #8591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffibm
force-pushed
the
log-collection-from-conversion
branch
2 times, most recently
from
ba3bfb5 to
3c32957
Compare
jeffibm
changed the title
jeffibm
force-pushed
the
log-collection-from-conversion
branch
from
fb05d54 to
fda6311
Compare
|
Checked commit jeffbonson@fda6311 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/views/ops/_log_collection.html.haml |
Fryguy
reviewed
Jan 9, 2023
| describe('Diagnostics Collect Log form component', () => { | ||
| const options = { | ||
| '': '<No Depot>', | ||
| FileDepotFtp: 'FTP', |
There was a problem hiding this comment.
were these hardcoded previously? I thought we offered them via OPTIONS
Fryguy
approved these changes
Jan 9, 2023
DavidResende0
approved these changes
Jan 9, 2023
Fryguy
reviewed
Jan 17, 2023
| const createSchema = (initialData, options) => { | ||
| const fields = [{ | ||
| component: componentTypes.SUB_FORM, | ||
| title: __(`Editing Log Depot Settings for ${initialData.logType}: ${initialData.displayName}`), |
There was a problem hiding this comment.
@jeffibm As per ManageIQ/manageiq#22309 (comment) this should probably be something like
Suggested change
| title: __(`Editing Log Depot Settings for ${initialData.logType}: ${initialData.displayName}`), | |
| title: sprintf(__(`Editing Log Depot Settings for %s: %s`), initialData.logType, initialData.displayName), |
There was a problem hiding this comment.
this change is handled in a different PR - #8605
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #7603 for
ops/_log_collection.html.hamlBefore
After
