-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update English Translations 2023-02-01T12:43:03Z #22309
Conversation
locale/en/manageiq.po
Outdated
"Editing Log Depot Settings for ${initialData.logType}: ${initialData.displayNa" | ||
"me}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong here - This shouldn't be using $
like this - @GilbertCherrie was this the form you changed recently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, I don't recognize log depot settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I'm sorry.
This was @jeffibm 's change in ManageIQ/manageiq-ui-classic#8591
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see it in the changes the bot added 19 hours ago:
Looks like this wasn't merged yet: ManageIQ/manageiq-ui-classic#8605
I'll merge and kick this github workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better... #22309 (comment)
831abe9
to
dcbe7bf
Compare
dcbe7bf
to
1690b94
Compare
Checked commit miq-bot@1690b94 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
#: ../app/views/ops/_log_collection.html.haml | ||
msgid "Editing Log Depot Settings for %{class}: %{display}" | ||
#: ../app/javascript/components/diagnostics-collect-log-form/schema.js | ||
msgid "Editing Log Depot Settings for %s: %s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, @jeffibm I think it's resolved now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm merging it.
Update the English Translations in the manageiq.po and manageiq.pot files.