Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English Translations 2023-02-01T12:43:03Z #22309

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

miq-bot
Copy link
Member

@miq-bot miq-bot commented Jan 15, 2023

Update the English Translations in the manageiq.po and manageiq.pot files.

Comment on lines 29403 to 29404
"Editing Log Depot Settings for ${initialData.logType}: ${initialData.displayNa"
"me}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here - This shouldn't be using $ like this - @GilbertCherrie was this the form you changed recently?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I don't recognize log depot settings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm sorry.

This was @jeffibm 's change in ManageIQ/manageiq-ui-classic#8591

Copy link
Member

@jrafanie jrafanie Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see it in the changes the bot added 19 hours ago:

image

Looks like this wasn't merged yet: ManageIQ/manageiq-ui-classic#8605

I'll merge and kick this github workflow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better... #22309 (comment)

@miq-bot miq-bot changed the title Update English Translations 2023-01-11T16:19:58Z Update English Translations 2023-01-31T21:07:36Z Feb 1, 2023
@miq-bot miq-bot force-pushed the update_english_translations branch from 831abe9 to dcbe7bf Compare February 1, 2023 00:44
@miq-bot miq-bot changed the title Update English Translations 2023-01-31T21:07:36Z Update English Translations 2023-02-01T12:43:03Z Feb 1, 2023
@miq-bot miq-bot force-pushed the update_english_translations branch from dcbe7bf to 1690b94 Compare February 1, 2023 20:09
@miq-bot
Copy link
Member Author

miq-bot commented Feb 1, 2023

Checked commit miq-bot@1690b94 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

#: ../app/views/ops/_log_collection.html.haml
msgid "Editing Log Depot Settings for %{class}: %{display}"
#: ../app/javascript/components/diagnostics-collect-log-form/schema.js
msgid "Editing Log Depot Settings for %s: %s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, @jeffibm I think it's resolved now

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm merging it.

@jrafanie jrafanie merged commit ba19595 into ManageIQ:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants