Host Edit Form React Conversion #8608

MelsHyrule · 2023-01-18T21:48:03Z

The Angular to React conversion for the Host Edit page. Part of #7603 and https://github.ibm.com/katamari/dev-issue-tracking/issues/42129#issuecomment-51911692

Will also remove IPMI fields ManageIQ/manageiq#21381

Related schema in providers

For reference
Verify Credentials Issue #6625

BEFORE

Single Host Selected

Multiple Hosts Selected

AFTER

Single Host Selected

Multiple Hosts Selected

app/javascript/components/host-edit-form/host-edit-form.jsx

jeffibm · 2023-02-21T10:02:05Z

app/javascript/components/host-edit-form/host-edit-form.jsx

+    setState((state) => ({
+      ...state,
+      ...appendState,
+      fields,


we can use fields: [] and avoid the const fields

MelsHyrule · 2023-03-23T16:23:45Z

@miq-bot add-reviewer @DavidResende0
@miq-bot add-reviewer @akhilkr128
@miq-bot add-reviewer @jeffibm
@miq-bot assign @jeffibm

cc @kbrock

MelsHyrule · 2023-03-23T16:54:59Z

NOTE: some follow up PRs were created for the schema, they will be needed to be able to properly test against this PR and they should be merged before this PR
ManageIQ/manageiq-providers-vmware#866
ManageIQ/manageiq-providers-ovirt#639
ManageIQ/manageiq-providers-openstack#843

Update: These PRs have all been merged 👌

DavidResende0 · 2023-03-28T18:06:38Z

app/javascript/components/host-edit-form/validate-host-credentials.jsx

+
+  const asyncValidate = (fields, fieldNames) => new Promise((resolve, reject) => {
+    const url = initialValues.host_validate_against ? `/api/hosts/${initialValues.host_validate_against}` : `/api/hosts/${ids[0]}`;
+    console.log(url);


Think you forgot this

DavidResende0

For the most part everything looks good, however I did stumble on this minor bug when reseting the form and then canceling, while editing multiple hosts.

Untitled.mov

MelsHyrule · 2023-03-31T16:01:56Z

Applied the fix @DavidResende0

DavidResende0

LGTM, although since this is a bigger pr I wouldn't mind a second set of eyes just in case I missed something.

jeffibm · 2023-04-05T05:04:35Z

@MelsHyrule , noticed a small change in new ui v/s old ui redirection on cancel event.

Screen.Recording.2023-04-05.at.10.21.56.AM.mov

jeffibm · 2023-04-05T05:08:03Z

app/views/host/_form.html.haml

+          - if session[:host_items]
+            - @embedded = true
+            = render :partial => 'layouts/gtl'
+= react('HostEditForm', { :ids => (@host.id ? [@host.id] : session[:host_items]) })


can avoid spaces before and after { }
= react('HostEditForm', {:ids => (@host.id ? [@host.id] : session[:host_items])})

Applied the change

jeffibm · 2023-04-05T05:09:40Z

@MelsHyrule , noticed a small change in new ui v/s old ui redirection on cancel event.

just saw David's comment, but could you please cross-check..

jeffibm

looks good to me..

miq-bot · 2023-04-10T16:38:46Z

Checked commit MelsHyrule@49f1e1b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
6 files checked, 2 offenses detected

app/views/host/_form.html.haml

⚠️ - Line 14 - Avoid using instance variables in partials views
⚠️ - Line 14 - Layout/TrailingEmptyLines: Final newline missing.

miq-bot · 2023-04-10T16:38:47Z

Checked commit MelsHyrule@49f1e1b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
6 files checked, 2 offenses detected

app/views/host/_form.html.haml

⚠️ - Line 14 - Avoid using instance variables in partials views
⚠️ - Line 14 - Layout/TrailingEmptyLines: Final newline missing.

MelsHyrule · 2023-04-11T19:48:35Z

@DavidResende0 @jeffibm applied the changes, are we good to merge?

DavidResende0 · 2023-04-11T19:50:11Z

@DavidResende0 @jeffibm applied the changes, are we good to merge?

I think you meant approved, but yeah I'll merge it now

MelsHyrule requested a review from a team as a code owner January 18, 2023 21:48

miq-bot added the wip label Jan 18, 2023

jeffibm mentioned this pull request Jan 19, 2023

Replace angular code #7603

Open

10 tasks

MelsHyrule mentioned this pull request Jan 19, 2023

Remove IPMI host provisioning ManageIQ/manageiq#21381

Open

MelsHyrule force-pushed the host-edit-form branch from ff917c7 to a70e6cc Compare January 24, 2023 21:15

This was referenced Jan 26, 2023

Introducing params_for_update schema fields for Hosts ManageIQ/manageiq-providers-ibm_power_hmc#132

Closed

Introducing params_for_update schema to Hosts ManageIQ/manageiq-providers-vmware#851

Merged

MelsHyrule force-pushed the host-edit-form branch from 1997385 to 719ebfa Compare February 1, 2023 20:11

miq-bot added the unmergeable label Feb 3, 2023

MelsHyrule force-pushed the host-edit-form branch 2 times, most recently from 276c5c0 to 9935982 Compare February 3, 2023 17:04

miq-bot removed the unmergeable label Feb 3, 2023

kbrock added enhancement react labels Feb 7, 2023

This was referenced Feb 13, 2023

Host validation ManageIQ/manageiq#22336

Merged

Host verify_credentials ManageIQ/manageiq-api#1202

Merged

jeffibm reviewed Feb 21, 2023

View reviewed changes

app/javascript/components/host-edit-form/host-edit-form.jsx Show resolved Hide resolved

jeffibm reviewed Feb 21, 2023

View reviewed changes

MelsHyrule force-pushed the host-edit-form branch 2 times, most recently from 434aa5b to 791ca7b Compare February 23, 2023 20:14

miq-bot added the unmergeable label Mar 1, 2023

MelsHyrule force-pushed the host-edit-form branch from 791ca7b to 5083da1 Compare March 2, 2023 17:43

miq-bot removed the unmergeable label Mar 2, 2023

MelsHyrule force-pushed the host-edit-form branch 3 times, most recently from a59d8ff to d6d73c7 Compare March 16, 2023 18:32

MelsHyrule force-pushed the host-edit-form branch 2 times, most recently from 0364f7c to fcfe4d8 Compare March 23, 2023 16:21

MelsHyrule changed the title ~~[WIP] Host page~~ Host page Mar 23, 2023

MelsHyrule changed the title ~~Host page~~ Host Form React Conversion Mar 23, 2023

MelsHyrule changed the title ~~Host Form React Conversion~~ Host Edit Form React Conversion Mar 23, 2023

MelsHyrule force-pushed the host-edit-form branch from fcfe4d8 to 29b7759 Compare March 23, 2023 16:22

miq-bot requested review from DavidResende0, akhilkr128 and jeffibm March 23, 2023 16:24

miq-bot assigned jeffibm Mar 23, 2023

miq-bot removed the wip label Mar 23, 2023

DavidResende0 reviewed Mar 28, 2023

View reviewed changes

MelsHyrule force-pushed the host-edit-form branch from ce34648 to 9b4fd16 Compare March 30, 2023 19:27

DavidResende0 approved these changes Apr 3, 2023

View reviewed changes

jeffibm reviewed Apr 5, 2023

View reviewed changes

jeffibm approved these changes Apr 5, 2023

View reviewed changes

MelsHyrule force-pushed the host-edit-form branch from 9b4fd16 to 4145af3 Compare April 10, 2023 16:37

Host page react conversion

49f1e1b

MelsHyrule force-pushed the host-edit-form branch from 4145af3 to 49f1e1b Compare April 10, 2023 16:37

DavidResende0 merged commit 6c11224 into ManageIQ:master Apr 11, 2023

jrafanie mentioned this pull request Nov 6, 2023

Remove Id from Host Endpoint When Submitting Form #8950

Merged

agrare mentioned this pull request Dec 19, 2023

Drop legacy Host credentials payload, replaced by DDF params ManageIQ/manageiq-api#1244

Merged

1 task

GilbertCherrie mentioned this pull request Jan 15, 2024

[Petrosian] Replace angular code #9031

Closed

11 tasks

agrare mentioned this pull request Jan 18, 2024

Fix Host default_authentication_type ManageIQ/manageiq-providers-vmware#895

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Host Edit Form React Conversion #8608

Host Edit Form React Conversion #8608

MelsHyrule commented Jan 18, 2023 •

edited by agrare

Loading

jeffibm Feb 21, 2023

MelsHyrule commented Mar 23, 2023

MelsHyrule commented Mar 23, 2023 •

edited

Loading

DavidResende0 Mar 28, 2023

DavidResende0 left a comment

MelsHyrule commented Mar 31, 2023

DavidResende0 left a comment

jeffibm commented Apr 5, 2023 •

edited

Loading

jeffibm Apr 5, 2023

MelsHyrule Apr 10, 2023

jeffibm commented Apr 5, 2023

jeffibm left a comment

miq-bot commented Apr 10, 2023

miq-bot commented Apr 10, 2023

MelsHyrule commented Apr 11, 2023

DavidResende0 commented Apr 11, 2023

Host Edit Form React Conversion #8608

Host Edit Form React Conversion #8608

Conversation

MelsHyrule commented Jan 18, 2023 • edited by agrare Loading

BEFORE

AFTER

jeffibm Feb 21, 2023

Choose a reason for hiding this comment

MelsHyrule commented Mar 23, 2023

MelsHyrule commented Mar 23, 2023 • edited Loading

DavidResende0 Mar 28, 2023

Choose a reason for hiding this comment

DavidResende0 left a comment

Choose a reason for hiding this comment

MelsHyrule commented Mar 31, 2023

DavidResende0 left a comment

Choose a reason for hiding this comment

jeffibm commented Apr 5, 2023 • edited Loading

jeffibm Apr 5, 2023

Choose a reason for hiding this comment

MelsHyrule Apr 10, 2023

Choose a reason for hiding this comment

jeffibm commented Apr 5, 2023

jeffibm left a comment

Choose a reason for hiding this comment

miq-bot commented Apr 10, 2023

miq-bot commented Apr 10, 2023

MelsHyrule commented Apr 11, 2023

DavidResende0 commented Apr 11, 2023

MelsHyrule commented Jan 18, 2023 •

edited by agrare

Loading

MelsHyrule commented Mar 23, 2023 •

edited

Loading

jeffibm commented Apr 5, 2023 •

edited

Loading