Remove old angular toolbar code for physical server page #8201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit GilbertCherrie@c986a35 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
jeffibm
approved these changes
Mar 29, 2022
kavyanekkalapu
approved these changes
Mar 29, 2022
This was referenced Apr 5, 2022
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7603
Removed old angular toolbar code that was added for the physical server page as part of this pr: #1380. The angular toolbar code was then replaced by api_buttons in the file: https://github.com/ManageIQ/manageiq-ui-classic/blob/dd33a325d6fd3605b25174838feee4c4806a804a/app/helpers/application_helper/toolbar/physical_servers_center.rb. This meant the angular toolbar was no longer needed and was removed but these lines were never removed with it.
API Response Before removing these lines:
API Response After removing these lines:
As the screenshot shows these changes have no effect on the toolbar functionality since the API response is still correct after removing these lines.
@miq-bot add_reviewer @kavyanekkalapu
@miq-bot assign @kavyanekkalapu
@miq-bot add-label technical-debt