Converted Add/Remove Security Groups Form to React #8112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilbertCherrie
force-pushed
the
add_security_group_form_conversion
branch
from
0617d5a to
32115ef
Compare
|
@miq-bot add_reviewer @kavyanekkalapu |
|
Checked commit GilbertCherrie@32115ef with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint app/views/vm_common/_add_security_group.html.haml
app/views/vm_common/_remove_security_group.html.haml |
|
@GilbertCherrie delete spec/javascripts/components/vm_cloud/vm-cloud-add-security-group_spec.js and spec/javascripts/components/vm_cloud/vm-cloud-remove-security-group_spec.js too |
MelsHyrule
approved these changes
Feb 11, 2022
GilbertCherrie
force-pushed
the
add_security_group_form_conversion
branch
2 times, most recently
from
719010d to
949d146
Compare
GilbertCherrie
force-pushed
the
add_security_group_form_conversion
branch
from
949d146 to
e99b7cf
Compare
|
Fixes #8119 |
kavyanekkalapu
approved these changes
Feb 14, 2022
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted Add/Remove Security Groups Form to React.
Before:
After:
