Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tenants -> Manage Quotas Form Conversion #8387

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Tenants -> Manage Quotas Form Conversion #8387

merged 1 commit into from
Sep 29, 2022

Conversation

DavidResende0
Copy link
Member

@DavidResende0 DavidResende0 commented Jul 27, 2022 •
edited
Loading

Fixes: #6866
Parent Issue: #7603

Form can be found in Application Settings->Access Control->Tenants->Manage Quotas

Before:
image

After:
image

@miq-bot miq-bot added the wip label Jul 27, 2022
@GilbertCherrie GilbertCherrie mentioned this pull request Aug 17, 2022
Open
10 tasks
@GilbertCherrie
Copy link
Member

@DavidResende0 Can you please also add #7603 as the parent issue

@DavidResende0 DavidResende0 requested a review from a team as a code owner September 22, 2022 17:59
@DavidResende0 DavidResende0 force-pushed the tenant-quota-form branch 2 times, most recently from 2047f9f to f621ac5 Compare September 22, 2022 21:12
@DavidResende0
Copy link
Member Author

@miq-bot add-reviewer @MelsHyrule, @jeffibm
@miq-bot add-label enhancement
@miq-bot assign @Fryguy

@DavidResende0 DavidResende0 changed the title [WIP] Tenants -> Manage Quotas Form Conversion Tenants -> Manage Quotas Form Conversion Sep 22, 2022
@miq-bot miq-bot removed the wip label Sep 22, 2022
@DavidResende0 DavidResende0 force-pushed the tenant-quota-form branch 6 times, most recently from 938a7f9 to cfc65e1 Compare September 28, 2022 17:42
@miq-bot
Copy link
Member

miq-bot commented Sep 28, 2022

Checked commit DavidResende0@5ef7da7 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
4 files checked, 2 offenses detected

app/views/ops/_tenant_quota_form.html.haml

  • ⚠️ - Line 2 - Avoid using instance variables in partials views
  • ⚠️ - Line 2 - Layout/TrailingEmptyLines: Final newline missing.

@jeffibm jeffibm merged commit d2aabad into ManageIQ:master Sep 29, 2022
@GilbertCherrie GilbertCherrie mentioned this pull request Oct 29, 2022
Closed
57 tasks
@DavidResende0 DavidResende0 mentioned this pull request Feb 17, 2023
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffibm jeffibm jeffibm approved these changes

@MelsHyrule MelsHyrule Awaiting requested review from MelsHyrule

Assignees

@Fryguy Fryguy

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form conversion: Configuration Access Control/Tenants/Manage Quotas
5 participants
@DavidResende0 @GilbertCherrie @miq-bot @jeffibm @Fryguy