feat: Provisioning for fw binaries #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 12869702495Details
💛 - Coveralls |
almaslennikov
force-pushed
the
fw-provisioning
branch
from
b74a496 to
3efb2ff
Compare
almaslennikov
force-pushed
the
fw-provisioning
branch
from
3efb2ff to
3ff1374
Compare
almaslennikov
force-pushed
the
fw-provisioning
branch
4 times, most recently
from
ce47fcc to
aa7dc94
Compare
Introduced two new CRDs: NicFirmwareSource and NicFirmwareTemplate New controller reconciling NicFirmwareSources firmware package with logic for provisioning firmware files on a shared storage unit tests Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
almaslennikov
force-pushed
the
fw-provisioning
branch
from
aa7dc94 to
13c0f57
Compare
rollandf
reviewed
Jan 20, 2025
| // NicFirmwareSourceSpec represents a list of url sources for FW | ||
| type NicFirmwareSourceSpec struct { | ||
| // BinUrlSource represents a list of url sources for FW | ||
| BinUrlSource []string `json:"binUrlSource"` |
There was a problem hiding this comment.
What is the meaning of the bin prefix? Is it needed?
Also should we have plural? binUrlSources
| mountPath: /nic-firmware | ||
| readOnly: false | ||
| # TODO change to user-specified storage class | ||
| volumes: |
There was a problem hiding this comment.
Just to make sure I understand, eventually we use a PVC with shared storage (ReadWriteMany)?
Where the PVC name will be configured?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced two new CRDs: NicFirmwareSource and NicFirmwareTemplate
New controller reconciling NicFirmwareSources
firmware package with logic for provisioning firmware files on a shared storage
unit tests
change docker base image for operator to rhel to install mstflint
TBD in separate PRs: