-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provisioning for fw binaries #60
Open
almaslennikov
wants to merge
2
commits into
Mellanox:main
Choose a base branch
from
almaslennikov:fw-provisioning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
2025 NVIDIA CORPORATION & AFFILIATES | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package v1alpha1 | ||
|
||
import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
||
// NicFirmwareSourceSpec represents a list of url sources for FW | ||
type NicFirmwareSourceSpec struct { | ||
// BinUrlSource represents a list of url sources for FW | ||
BinUrlSource []string `json:"binUrlSource"` | ||
} | ||
|
||
// NicFirmwareSourceStatus represents the status of the FW from given sources, e.g. version available for PSIDs | ||
type NicFirmwareSourceStatus struct { | ||
// State represents the firmware processing state, e.g. Downloading|Processing|Success|ProcessingFailed|DownloadFailed | ||
State string `json:"state"` | ||
// Reason shows an error message if occurred | ||
Reason string `json:"reason,omitempty"` | ||
// Versions is a map of available FW versions to PSIDs | ||
// a PSID should have only a single FW version available for it | ||
Versions map[string][]string `json:"versions,omitempty"` | ||
} | ||
|
||
//+kubebuilder:object:root=true | ||
//+kubebuilder:subresource:status | ||
|
||
// NicFirmwareSource is the Schema for the nicfirmwaresources API | ||
type NicFirmwareSource struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
Spec NicFirmwareSourceSpec `json:"spec,omitempty"` | ||
Status NicFirmwareSourceStatus `json:"status,omitempty"` | ||
} | ||
|
||
//+kubebuilder:object:root=true | ||
|
||
// NicFirmwareSourceList contains a list of NicFirmwareSource | ||
type NicFirmwareSourceList struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ListMeta `json:"metadata,omitempty"` | ||
Items []NicFirmwareSource `json:"items"` | ||
} | ||
|
||
func init() { | ||
SchemeBuilder.Register(&NicFirmwareSource{}, &NicFirmwareSourceList{}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/* | ||
2025 NVIDIA CORPORATION & AFFILIATES | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package v1alpha1 | ||
|
||
import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
||
// FirmwareTemplateSpec specifies a FW update policy for a given FW source ref | ||
type FirmwareTemplateSpec struct { | ||
// NicFirmwareSourceRef refers to existing NicFirmwareSource CR on where to get the FW from | ||
// +required | ||
NicFirmwareSourceRef string `json:"nicFirmwareSourceRef"` | ||
// UpdatePolicy indicates whether the operator needs to validate installed FW or upgrade it | ||
// +kubebuilder:validation:Enum=Validate;Update | ||
// +required | ||
UpdatePolicy string `json:"updatePolicy"` | ||
} | ||
|
||
// NicFirmwareTemplateSpec defines the FW templates and node/nic selectors for it | ||
type NicFirmwareTemplateSpec struct { | ||
// NodeSelector contains labels required on the node | ||
NodeSelector map[string]string `json:"nodeSelector,omitempty"` | ||
// NIC selector configuration | ||
// +required | ||
NicSelector *NicSelectorSpec `json:"nicSelector"` | ||
// Firmware update template | ||
// +required | ||
Template *FirmwareTemplateSpec `json:"template"` | ||
} | ||
|
||
// NicFirmwareTemplateStatus lists the NicDevice CRs matching the FW template | ||
type NicFirmwareTemplateStatus struct { | ||
// NicDevice CRs matching this firmware template | ||
NicDevices []string `json:"nicDevices"` | ||
} | ||
|
||
//+kubebuilder:object:root=true | ||
//+kubebuilder:subresource:status | ||
|
||
// NicFirmwareTemplate is the Schema for the nicfirmwaretemplates API | ||
type NicFirmwareTemplate struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
Spec NicFirmwareTemplateSpec `json:"spec,omitempty"` | ||
Status NicFirmwareTemplateStatus `json:"status,omitempty"` | ||
} | ||
|
||
//+kubebuilder:object:root=true | ||
|
||
// NicFirmwareTemplateList contains a list of NicFirmwareTemplate | ||
type NicFirmwareTemplateList struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ListMeta `json:"metadata,omitempty"` | ||
Items []NicFirmwareTemplate `json:"items"` | ||
} | ||
|
||
func init() { | ||
SchemeBuilder.Register(&NicFirmwareTemplate{}, &NicFirmwareTemplateList{}) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the meaning of the
bin
prefix? Is it needed?Also should we have plural?
binUrlSources