Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nsys-jax] Add ratio of hidden communication time to total communication time #1241

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

sfvaroglu
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sfvaroglu sfvaroglu requested a review from olupton January 10, 2025 18:07
olupton
olupton previously approved these changes Jan 14, 2025
Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a first iteration.

In terms of plumbing these new metrics into a monitoring system, wouldn't it be better to also write them to a machine-readable file? Otherwise you would have to e.g. grep numbers back out of the prettytable.

I don't think there is currently test coverage for this, but the intent is that files written by the analysis recipes are saved to the output .zip.

Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@olupton olupton merged commit eb6d0d2 into main Jan 16, 2025
90 of 99 checks passed
@olupton olupton deleted the sevin/comm_time branch January 16, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants