Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos fix #2329

Closed
wants to merge 5 commits into from
Closed

Typos fix #2329

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa50e74
typo-Update CODE_OF_CONDUCT.md
romashka-btc Dec 16, 2024
e53b181
typo-Update state.go
romashka-btc Dec 16, 2024
da32b7f
typo-Update db.go
romashka-btc Dec 16, 2024
368fb7c
typo2-Update CODE_OF_CONDUCT.md
romashka-btc Dec 20, 2024
c208520
Delete CODE_OF_CONDUCT.md
romashka-btc Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a mistake here, you have removed a whole CODE_OF_CONDUCT.md

Copy link
Author

@romashka-btc romashka-btc Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a mistake here, you have removed a whole CODE_OF_CONDUCT.md

hmmm, and what you reccomend to do now ? @AnkushinDaniil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c
Try reverting to this commit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c Try reverting to this commit

ok, i will do it in 5-8 hours, pls do not close it, because i need go to work now. @AnkushinDaniil thank you !

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c Try reverting to this commit

i can not reverting it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c Try reverting to this commit

maybe you will add only another changes ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnkushinDaniil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry, but I can't. Why not have a go at finding out how to do that yourself? I'm sure you'd be able to manage it, it's not that difficult.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry, but I can't. Why not have a go at finding out how to do that yourself? I'm sure you'd be able to manage it, it's not that difficult.

i do not understaand what i need to do. can you help me?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All you need to do to get things back to where they should be is either revert the last commit or add one more commit that reverts your last change

Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Read carefully our Contributing Guidelines to know how to contribute properly in
project. Members and maintainers must adhere to some rules regarding to pull requests
reviews and creation of issues and pull requests:

* During code reviews do not comment on coding standards and styles -focus on algorithmical,
* During code reviews do not comment on coding standards and styles -focus on algorithmic,
structural or naming issues-, help to solve problem.
* When creating an issue or a pull request, follow the templates provided by the repository and
fill in the indicated items correctly. If you do not want to use a template, open a blank issue/PR
Expand Down
2 changes: 1 addition & 1 deletion core/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ func (s *State) updateContractStorages(stateTrie *trie.Trie, diffs map[felt.Felt
}
}

// sort the contracts in decending diff size order
// sort the contracts in descending diff size order
// so we start with the heaviest update first
keys := slices.SortedStableFunc(maps.Keys(diffs), func(a, b felt.Felt) int { return len(diffs[a]) - len(diffs[b]) })

Expand Down
2 changes: 1 addition & 1 deletion db/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func discardTxnOnPanic(txn Transaction) {
p := recover()
if p != nil {
if err := txn.Discard(); err != nil {
fmt.Fprintf(os.Stderr, "failed discarding panicing txn err: %s", err)
fmt.Fprintf(os.Stderr, "failed discarding panicking txn err: %s", err)
}
panic(p)
}
Expand Down