Skip tests BlockWithReceipts due to invalid test asserts #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test expects transaction_hash in the transaction object, but according to the spec, it's only required under receipt.
AnkushinDaniil
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2374 +/- ##
==========================================
- Coverage 74.70% 74.66% -0.04%
==========================================
Files 110 110
Lines 12021 12021
==========================================
- Hits 8980 8976 -4
- Misses 2349 2351 +2
- Partials 692 694 +2 ☔ View full report in Codecov by Sentry. |
rodrigo-pino
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are incorrect because they expect transaction_hash in the transaction object, while the spec only requires it in the receipt. Skipping them for now in our pipeline, and will unskip them once the framework fixes the tests.