nixos/wyoming-faster-whisper: remove ProcSubset protection #372898
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
itz-Jana
force-pushed
the
wyoming-faster-whisper-remove-proc-protection
branch
from
4d51d62 to
93a5596
Compare
ProcSubset protection blocks faster-whisper from parsing /proc/cpuinfo This results in a fallback to a suboptimal processing method, causing processing times to be unnecessarily long
itz-Jana
force-pushed
the
wyoming-faster-whisper-remove-proc-protection
branch
from
93a5596 to
b1ed2e4
Compare
itz-Jana
changed the title
LordGrimmauld
approved these changes
Jan 13, 2025
|
Thank you for testing whether I pinged Hexa, they know systemd hardening and are part of the home-automation team, so that is probably the right person. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProcSubset protection blocks faster-whisper from parsing /proc/cpuinfo resulting in this error message:
This results in a fallback to a suboptimal processing method, causing processing times to be unnecessarily long.
In particular this caused processing of a 3 second clip with a small-int8 model to take about 20 seconds on my i5-12400, fully loading 4 threads.
After the change it is able to process in about 3 seconds with minimal load.
I have not seen a way to limit access only to
/proc/cpuinfospecifically, but maybe someone else has an idea.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.