Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/wyoming-faster-whisper: remove ProcSubset protection #372898

Merged
merged 1 commit into from
Jan 13, 2025
+2 −1
Merged

nixos/wyoming-faster-whisper: remove ProcSubset protection #372898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nixos/modules/services/home-automation/wyoming/faster-whisper.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,8 @@ in
ProtectKernelTunables = true;
ProtectControlGroups = true;
ProtectProc = "invisible";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As documented in https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#ProtectProc=, ProtectProc only limits access to other processes, not to non-process files like /proc/cpuinfo. I believe you should be able to get away just dropping the ProcSubset definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I misread that then, I'll give it a try and change it if it works!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LordGrimmauld Yup, works as you described. Re-added ProtectProc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the line, set the value to all and add a comment, why we need this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweinelt Done

ProcSubset = "pid";
# "all" is required because faster-whisper accesses /proc/cpuinfo to determine cpu capabilities
ProcSubset = "all";
RestrictAddressFamilies = [
"AF_INET"
"AF_INET6"
Expand Down