Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/renovate: Fix ShellCheck issue #373131

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jan 12, 2025

Tracking issue #349572.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 12, 2025
@l0b0 l0b0 requested review from Scrumplex, emilazy and nikstur January 12, 2025 09:12
@l0b0
Copy link
Contributor Author

l0b0 commented Jan 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373131


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 5 packages built:
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references

@l0b0
Copy link
Contributor Author

l0b0 commented Jan 12, 2025

My runs of nix-build -A nixosTests.renovate got stuck in a loop, with the last two lines repeating seemingly indefinitely:

machine # [   11.548947] gitea[878]: 2025/01/12 09:38:01 ...s/graceful/server.go:50:NewServer() [I] Starting new Web server: tcp:0.0.0.0:3000 on PID: 878
machine: Guest root shell did not produce any data yet...
machine:   To debug, enter the VM and run 'systemctl status backdoor.service'.
machine: Guest root shell did not produce any data yet...
machine:   To debug, enter the VM and run 'systemctl status backdoor.service'.

So:

@ofborg test renovate

@l0b0 l0b0 force-pushed the shellcheck-renovate-systemd-scripts branch from ebf9bbb to de69320 Compare January 12, 2025 11:58
@l0b0
Copy link
Contributor Author

l0b0 commented Jan 12, 2025

My runs of nix-build -A nixosTests.renovate got stuck in a loop, with the last two lines repeating seemingly indefinitely:
[…]

Turns out systemd.enableStrictShellChecks = true itself was causing the boot to hang!

@l0b0
Copy link
Contributor Author

l0b0 commented Jan 12, 2025

@ofborg test renovate

@l0b0 l0b0 force-pushed the shellcheck-renovate-systemd-scripts branch from c585214 to 9ec8ebf Compare January 12, 2025 13:47
@l0b0 l0b0 requested a review from Scrumplex January 12, 2025 13:50
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Jan 12, 2025
@Scrumplex Scrumplex merged commit c415811 into NixOS:master Jan 13, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants