[FIX] account_statement_import_online_gocardless : token/refresh endpoint #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpol-dev
force-pushed
the
16.0-arpol
branch
from
2131017 to
0a4e9cc
Compare
…f the endpoint token/refresh request datas, plus the behavior of the _gocardless_get_token method which in case of a non expired refresh token was calling the endpoint token/new instead of token/refresh
|
@pedrobaeza @njeudy |
pedrobaeza
reviewed
Jan 7, 2025
| @@ -84,17 +84,17 @@ def _gocardless_get_token(self): | |||
| # Refresh token | |||
| if ( | |||
| self.gocardless_refresh_token | |||
| and now > self.gocardless_refresh_expiration | |||
| and now < self.gocardless_refresh_expiration | |||
There was a problem hiding this comment.
@pedrobaeza refresh_token can be used if it is still valid, else, you should use "create new token".
| ): | ||
| endpoint = "token/refresh" | ||
| request_data = {"refresh": self.gocardless_refresh_token} |
There was a problem hiding this comment.
if you use "refresh" and not 'create new' you can update openbanking authorization vith the valid refresh token, else, create new.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of the endpoint token/refresh request datas that were not correctly set up, this request expects the refresh token but not the secret_id and secret_key.
Plus the behavior of the _gocardless_get_token method was calling the endpoint "token/new" instead of "token/refresh" in case of a non expired refresh token.