[16.0][mig] account_banking_ach_base #128
Conversation
Co-authored-by: Daniel Reis <dreis@opensourceintegrators.com>
…xcept space,comma and underscore because these special characters are accepted while creating a file
[FIX] account_banking_ach_base: use the payment_ids field instead of bank_line_ids Applies same fix as OCA#101 amount_currency no longer available in 16 (Changed to amount) communicaton field no longer available in 16 (Changed to ref)
JasminSForgeFlow
force-pushed
the
16.0-MIG-account_banking_ach_base
branch
from
683d628 to
df06297
Compare
|
@JordiBForgeFlow @JasminSForgeFlow would U need help with failing checks? Is this ready for code review? Is there anything I can do to help? |
Hi, |
| "website": "https://github.com/OCA/l10n-usa", | ||
| "category": "Banking addons", | ||
| "depends": [ | ||
| "account_payment_order", |
There was a problem hiding this comment.
Since it's a dependency in another oca repository I'll suggest the use of oca_dependencies.txt
| "category": "Banking addons", | ||
| "depends": [ | ||
| "account_payment_order", | ||
| "account_banking_mandate", |
| "l10n_us_partner_legal_number", | ||
| ], | ||
| "data": [ | ||
| "views/account_banking_mandate.xml", |
There was a problem hiding this comment.
According to Odoo's guidelines which are the base for ours this file's name should be suffixed with "_views". The renaming should be done with "git move" command.
| ], | ||
| "data": [ | ||
| "views/account_banking_mandate.xml", | ||
| "views/account_move.xml", |
| "data": [ | ||
| "views/account_banking_mandate.xml", | ||
| "views/account_move.xml", | ||
| "views/res_bank.xml", |
| "views/account_banking_mandate.xml", | ||
| "views/account_move.xml", | ||
| "views/res_bank.xml", | ||
| "views/res_company.xml", |
| "views/res_bank.xml", | ||
| "views/res_company.xml", | ||
| ], | ||
| "external_dependencies": {"python": ["python-stdnum", "ach"]}, |
There was a problem hiding this comment.
OCA's Contributing guidelines suggest put installation instructions for these as part of the INSTALLATION section of README
| def set_payment_modes_on_partner(self): | ||
| """ | ||
| Set the payment modes on the Partner if they don't already exist. | ||
| """ |
There was a problem hiding this comment.
| """ | |
| """ | |
| self.ensure_one() |
|
Good morning, During the functional review, I have detected an error related to traceability. This problem occurs when creating a customer invoice with the payment mode configured as ACH Customers and with a bank mandate set up. When trying to add the line item to a debit mandate, the system threw the following traceability error: Traceback (most recent call last): The above server error caused the following client error: I remain attentive to any additional questions or clarifications you may need to resolve this issue. Thank you very much in advance |
| _( | ||
| "To satisfy payment mandate, cannot add " | ||
| "invoice %(name)s to Debit Order until %(delay_expired)s!" | ||
| ), |
There was a problem hiding this comment.
Analizing the traceback from @lauradiaz22 I think this should solve the issue.
| "invoice %(name)s to Debit Order until %(delay_expired)s!" | ||
| ), | ||
| name=invoice.name, | ||
| delay_expired=delay_expired.strftime("%Y-%m-%d"), |
There was a problem hiding this comment.
| delay_expired=delay_expired.strftime("%Y-%m-%d"), | |
| delay_expired=delay_expired.strftime("%Y-%m-%d")) |
|
@lauradiaz22, thank you for your input. While I’m not the author of the PR, I am serving as a technical reviewer. The issue you identified is valid; however, I believe there’s a potential workaround. Based on the section of code triggering the issue, it seems likely that the problem lies with the bank mandate configuration. If the code were functioning as intended, you would have seen a UserError popup with a message similar to the following:
Unless that was exactly what you were trying to accomplish. I have requested some changes to @JordiBForgeFlow to fix the issue you just detected. |
Superseeds #97