Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_banking_ach_base #97

Open
wants to merge 20 commits into
base: 16.0
Choose a base branch
from

Conversation

Hardik-OSI
Copy link

No description provided.

@patrickrwilson patrickrwilson force-pushed the 16.0-MIG-account_banking_ach_base branch 2 times, most recently from 6d152ab to 43ffafa Compare April 14, 2023 19:40
[FIX] account_banking_ach_base: use the payment_ids field instead of bank_line_ids

Applies same fix as OCA#101

amount_currency no longer available in 16 (Changed to amount)

communicaton field no longer available in 16 (Changed to ref)
@lauradiaz22
Copy link

Good morning,

During the functional review, I have detected an error related to traceability. This problem occurs when creating a customer invoice with the payment mode configured as ACH Customers and with a bank mandate set up.

When trying to add the line item to a debit mandate, the system threw the following traceability error:

Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1652, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 133, in retrying
result = func()
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1679, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1883, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 734, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 46, in call_button
action = self._call_kw(model, method, args, kwargs)
File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 33, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 468, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 453, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/odoo/auto/addons/account_banking_ach_base/models/account_move.py", line 19, in create_account_payment_line
raise UserError(
TypeError: UserError.init() got an unexpected keyword argument 'name'

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
RPC_ERROR
at makeErrorFromResponse (http://10.10.10.72:16069/web/assets/459-123235e/web.assets_backend.min.js:997:163)
at XMLHttpRequest. (http://10.10.10.72:16069/web/assets/459-123235e/web.assets_backend.min.js:1005:13)

I remain attentive to any additional questions or clarifications you may need to resolve this issue.

Thank you very much in advance

@JasminSForgeFlow
Copy link

Good morning,

During the functional review, I have detected an error related to traceability. This problem occurs when creating a customer invoice with the payment mode configured as ACH Customers and with a bank mandate set up.

When trying to add the line item to a debit mandate, the system threw the following traceability error:

Traceback (most recent call last): File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1652, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 133, in retrying result = func() File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1679, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1883, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch result = endpoint(**request.params) File "/opt/odoo/custom/src/odoo/odoo/http.py", line 734, in route_wrapper result = endpoint(self, *args, **params_ok) File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 46, in call_button action = self._call_kw(model, method, args, kwargs) File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 33, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "/opt/odoo/custom/src/odoo/odoo/api.py", line 468, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "/opt/odoo/custom/src/odoo/odoo/api.py", line 453, in _call_kw_multi result = method(recs, *args, **kwargs) File "/opt/odoo/auto/addons/account_banking_ach_base/models/account_move.py", line 19, in create_account_payment_line raise UserError( TypeError: UserError.init() got an unexpected keyword argument 'name'

The above server error caused the following client error: RPC_ERROR: Odoo Server Error RPC_ERROR at makeErrorFromResponse (http://10.10.10.72:16069/web/assets/459-123235e/web.assets_backend.min.js:997:163) at XMLHttpRequest. (http://10.10.10.72:16069/web/assets/459-123235e/web.assets_backend.min.js:1005:13)

I remain attentive to any additional questions or clarifications you may need to resolve this issue.

Thank you very much in advance

Can you please review #128? this MR is surpassed.
Thanks.

@lauradiaz22
Copy link

Good morning,
Thank you very much for the warning. Indeed, the Pull Request that I tested and that generated the mentioned error was #128. I will proceed to move the comment to the corresponding place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants