Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] pos_partner_birthdate: fixing this.changes state #1071

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[16.0][FIX] pos_partner_birthdate: fixing this.changes state #1071

merged 1 commit into from
Nov 2, 2023

Conversation

imbarbudiman
Copy link
Contributor

use useState when add birthdate_date to changes state

@OCA-git-bot
Copy link
Contributor

Hi @ecino,
some modules you are maintaining are being modified, check this out!

chienandalu
chienandalu reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG @imbarbudiman 👍

please merge your commits into one

nitpick: a better desprition of the commit: [FIX] pos_partner_birthdate: PartnerDetailsEdit reactivity

pos_partner_birthdate/static/src/js/ClientDetailsEdit.esm.js Outdated Show resolved Hide resolved
@imbarbudiman imbarbudiman force-pushed the pos_partner_birthdate_changes_usesstate branch from 6c46d74 to 87c144b Compare November 2, 2023 11:57
@imbarbudiman
Copy link
Contributor Author

LG @imbarbudiman 👍

please merge your commits into one

nitpick: a better desprition of the commit: [FIX] pos_partner_birthdate: PartnerDetailsEdit reactivity

commits merged

@chienandalu chienandalu requested a review from ecino November 2, 2023 12:05
@chienandalu chienandalu added this to the 16.0 milestone Nov 2, 2023
ecino
ecino approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chienandalu
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1071-by-chienandalu-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ed4299f into OCA:16.0 Nov 2, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d22dcb0. Thanks a lot for contributing to OCA. ❤️

@imbarbudiman imbarbudiman mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecino ecino ecino approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@imbarbudiman @OCA-git-bot @chienandalu @ecino