[16.0] pos_partner_firstname: fix string #1074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robyf70, |
alexis-via
force-pushed
the
16-pos_partner_firstname-fix-string
branch
from
bf43d8e to
a932140
Compare
legalsylvain
reviewed
Nov 3, 2023
| @@ -45,7 +45,7 @@ odoo.define("pos_partner_firstname.PartnerDetailsEdit", function (require) { | |||
| processedChanges.lastname === "" | |||
| ) { | |||
| return this.showPopup("ErrorPopup", { | |||
| title: _t("Both Customer First and Last Name Are Required"), | |||
| title: _t("Both customer first name and last name are required."), | |||
There was a problem hiding this comment.
are you sure on this one ?
There was a problem hiding this comment.
This is involved in v17 here #1126
|
Hi @alexis-via |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of bad string you only see when working on PO files !