Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] pos_partner_firstname: fix string #1074

Closed
wants to merge 1 commit into from
Closed

[16.0] pos_partner_firstname: fix string #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pos_partner_firstname/static/src/js/PartnerDetailsEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ odoo.define("pos_partner_firstname.PartnerDetailsEdit", function (require) {
processedChanges.lastname === ""
) {
return this.showPopup("ErrorPopup", {
title: _t("Both Customer First and Last Name Are Required"),
title: _t("Both customer first name and last name are required."),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure on this one ?

https://www.deepl.com/translator#fr/en/Le%20nom%20et%20le%20pr%C3%A9nom%20du%20client%20sont%20obligatoires

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is involved in v17 here #1126

});
}
if (
Expand Down
4 changes: 2 additions & 2 deletions pos_partner_firstname/static/src/xml/pos.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
name="lastname"
t-on-change="captureChange"
t-att-value="props.partner.lastname || ''"
placeholder="LastName"
placeholder="Last Name"
/>
</div>
</div>
Expand All @@ -45,7 +45,7 @@
name="firstname"
t-on-change="captureChange"
t-att-value="props.partner.firstname || ''"
placeholder="FirstName"
placeholder="First Name"
/>
</div>
</div>
Expand Down
Loading