Dedicated parachain runtime (First try) #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 16, 2023 15:19
Although I'm not sure _why_ it compiles. It seems like I have the generics to validate_block wrong.
added 25 commits
November 17, 2023 16:17
…features like XCM and custom head data that are currently out of scope.
|
Closing in favor of #198 |
JoshOrndorff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116 (if merged all the way to main)
This PR (which is currently based off of #130) introduces a dedicated parachain runtime instead of having a
parachainfeature in the existing runtime.This solves a problem that when you simply ran
cargo build --releasein the repo, it would build the runtime with the parachain feature which meant the sovereign node would be broken.But don't worry! This does not bring back (much) code duplication. We are able to take the sovereign runtime's constraint checker and use it as a constituent piece in the parachain's checker. This is all thanks to out aggregation macro's focus on recursion.
I included some comments to flex that our design is nicer than FRAME's in this regard.
One remaining issue is that the wallet can't decode the transactions properly (because the aggregate enum is one layer deeper and thus the encoding is one byte longer).