-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated Parachain Runtime #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternate approach to keeping the wallet compatible with both runtimes would be to do a layer of dummy wrapping directly in the regular template runtime. |
…int checker. Use opaque block in more places.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
JoshOrndorff
commented
Apr 2, 2024
Comment on lines
+24
to
+26
#[arg(long, short('d'))] | ||
/// Path where the wallet data is stored. Default value is platform specific. | ||
pub path: Option<PathBuf>, | ||
pub base_path: Option<PathBuf>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wallet now uses the same long and short flag as the node itself, and this frees up -p
for the new --parachain
flag.
JoshOrndorff
force-pushed
the
joshy-dedicated-parachain-runtime-2
branch
from
April 2, 2024 17:21
1c72a85
to
94f63b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116. Second try after #150.
This PR introduces a dedicated parachain runtime instead of having a parachain feature in the existing runtime.
This solves a problem that when you simply ran cargo build --release in the repo, it would build the runtime with the parachain feature which meant the sovereign node would be broken.
But don't worry! This does not bring back (much) code duplication. We are able to take the sovereign runtime's constraint checker and use it as a constituent piece in the parachain's checker. This is all thanks to out aggregation macro's focus on recursion.
I included some comments to flex that our design is nicer than FRAME's in this regard.
The wallet also has some changes to support this.
--parachain
flag. This paves the way to start experimenting with metadata (Metadata #30).