Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONFIG] Taxon sheet and config #3312

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[CONFIG] Taxon sheet and config #3312

wants to merge 7 commits into from
+116 −81

Conversation

edelclaux
Copy link
Contributor

Closes #3311

  • Ajout de l'option ENABLE_TAXON_SHEETS
  • Modification des options SYNTHESE.TAXON_SHEET.ENABLE_XXX en SYNTHESE.TAXON_SHEET.ENABLE_TAB_XXX

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (926585d) to head (17678ab).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
backend/geonature/utils/config_schema.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3312   +/-   ##
========================================
  Coverage    83.93%   83.93%           
========================================
  Files          122      122           
  Lines         9715     9723    +8     
========================================
+ Hits          8154     8161    +7     
- Misses        1561     1562    +1
Flag Coverage Δ
pytest 83.93% <96.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jacquesfize
jacquesfize approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jacquesfize jacquesfize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A part quelques modifications de codes, tout fonctionne !

backend/geonature/core/gn_synthese/routes.py

# Subquery to fetch areas based on area_type
areas_subquery = (
select([LAreas.id_area])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select([LAreas.id_area])
select(LAreas.id_area)

backend/geonature/core/gn_synthese/routes.py
Comment on lines +992 to +993
.where(LAreas.id_type == BibAreasTypes.id_type)
.where(BibAreasTypes.type_code == area_type)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.where(LAreas.id_type == BibAreasTypes.id_type)
.where(BibAreasTypes.type_code == area_type)
.where(LAreas.id_type == BibAreasTypes.id_type, BibAreasTypes.type_code == area_type)

backend/geonature/utils/config.py Outdated Show resolved Hide resolved
@jacquesfize jacquesfize added this to the 2.15.2 milestone Jan 13, 2025
@edelclaux @jacquesfize
Remove obsolete comment
17678ab 
Co-authored-by: Jacques Fize <4259846+jacquesfize@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillemonchicourt camillemonchicourt camillemonchicourt left review comments

@jacquesfize jacquesfize jacquesfize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@edelclaux @jacquesfize @camillemonchicourt