Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QEDprocess functionality #25

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented Jun 18, 2024

This adds the functionality from QEDprocesses again which was temporarily removed from #6 / #23 to have a working state.

Must be merged after QEDbase is released with the new interfaces from QEDprocesses.

@AntonReinhard AntonReinhard force-pushed the add_functionality branch 3 times, most recently from cab5fb8 to ea2e8fb Compare June 20, 2024 08:37
@AntonReinhard
Copy link
Member Author

This should be ready to merge and successfully test once QEDjl-project/QEDbase.jl#68 is merged

@szabo137
Copy link
Member

@AntonReinhard please update QEDbase and push again.

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Since it is copied from QEDprocesses, it was already reviewed there.

@szabo137 szabo137 merged commit cc4895d into QEDjl-project:dev Jun 26, 2024
2 checks passed
@AntonReinhard AntonReinhard deleted the add_functionality branch June 26, 2024 09:19
szabo137 added a commit that referenced this pull request Jun 27, 2024
This PR revokes the namespace changes done before QEDbase.jl 0.2 was
released.

Currently based on #25,
I will rebase once that is merged.
@AntonReinhard AntonReinhard added this to the Release 0.1.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants