Add Lorentz Boosts #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabo137
force-pushed
the
dev-lorentz_trafo
branch
from
ffd060e to
ca05028
Compare
|
@AntonReinhard Sorry, it ends up being a bit longer, but I think now it's ready for review 😅 |
There was a problem hiding this comment.
Mostly small suggestions, since I can't really comment on the physics involved 😉
I hope you checked that the maths environments render correctly in the documentation?
And as commented at the specific points too, I'd request not leaving larger TODOs in the code and instead opening issues.
szabo137
commented
Sep 18, 2024
szabo137
commented
Oct 7, 2024
AntonReinhard
previously approved these changes
Oct 8, 2024
Closed
4 tasks
Co-authored-by: Anton Reinhard <anton.reinhard@proton.me>
szabo137
force-pushed
the
dev-lorentz_trafo
branch
from
952f113 to
deac722
Compare
szabo137
added a commit
to QEDjl-project/QEDbase.jl
that referenced
this pull request
Oct 11, 2024
Following the suggestion made here: QEDjl-project/QEDcore.jl#45 (comment) --------- Co-authored-by: Uwe Hernandez Acosta <u.hernandez@hzdr.de> Co-authored-by: Anton Reinhard <anton.reinhard@proton.me>
AntonReinhard
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Lorentz boosts in two variants:
BetaVector), see here or here for details.Solves #18
TODOS