-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation and Manuals #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution! Looks good to me, I just request some minor changes 🙆♂️
Feel free to merge if changes got applied.
9a59c6f
to
3c3aacf
Compare
dacfa11
to
6d840ae
Compare
6d840ae
to
cf5f65d
Compare
This has one temporary docstring from the QEDbase_patch.jl which I'll remove in a separate PR when the patch is remove. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM. I think we can leave the TBW
in, because the BiVectors need a refac anyway.
Merge after #69 This deletes the QEDbase patch which is no longer necessary as the relevant PR in QEDbase was merged. Unfortunately, there seems to be a somewhat strange interaction of doubly defined typenames and `@reexport`, creating an issue in QEDbase's documentation building. This means that I had to remove some `@extref` statements for now that can be readded later, when QEDbase is ready.
In the same spirit as the respective QEDbase PR, this adds some documentation, orders the functions into a (hopefully more useful) library category, and adds some manuals for the main features with usage examples.
The vectors manual is currently more of a place holder because I don't know enough about them to write a good manual. I would refer this task to @szabo137 or @steindev .
The phase space definition manual is also a placeholder, because it will be reworked soon anyway (see #50).