Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and Manuals #69

Merged
merged 9 commits into from
Oct 22, 2024
Merged

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented Oct 11, 2024

In the same spirit as the respective QEDbase PR, this adds some documentation, orders the functions into a (hopefully more useful) library category, and adds some manuals for the main features with usage examples.

  • Once the QEDbase PR is merged, the @extref in particles.jl has to be enabled.

The vectors manual is currently more of a place holder because I don't know enough about them to write a good manual. I would refer this task to @szabo137 or @steindev .
The phase space definition manual is also a placeholder, because it will be reworked soon anyway (see #50).

szabo137
szabo137 previously approved these changes Oct 11, 2024
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Looks good to me, I just request some minor changes 🙆‍♂️

Feel free to merge if changes got applied.

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
docs/src/tutorial/particles.jl Outdated Show resolved Hide resolved
szabo137
szabo137 previously approved these changes Oct 21, 2024
@AntonReinhard AntonReinhard marked this pull request as ready for review October 21, 2024 14:41
@AntonReinhard
Copy link
Member Author

This has one temporary docstring from the QEDbase_patch.jl which I'll remove in a separate PR when the patch is remove.

@AntonReinhard AntonReinhard mentioned this pull request Oct 21, 2024
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM. I think we can leave the TBW in, because the BiVectors need a refac anyway.

@szabo137 szabo137 merged commit fc1483b into QEDjl-project:dev Oct 22, 2024
4 checks passed
SimeonEhrig pushed a commit that referenced this pull request Oct 23, 2024
Merge after #69 

This deletes the QEDbase patch which is no longer necessary as the
relevant PR in QEDbase was merged.
Unfortunately, there seems to be a somewhat strange interaction of
doubly defined typenames and `@reexport`, creating an issue in QEDbase's
documentation building. This means that I had to remove some `@extref`
statements for now that can be readded later, when QEDbase is ready.
@AntonReinhard AntonReinhard deleted the documentation branch October 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants