-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call compile with correct executable #3493
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3493 +/- ##
========================================
Coverage 92.17% 92.17%
========================================
Files 512 512
Lines 21385 21385
========================================
Hits 19712 19712
Misses 1673 1673 ☔ View full report in Codecov by Sentry. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
@@ -228,9 +228,15 @@ std::vector<std::vector<char>> compile_hip_src_with_hiprtc(std::vector<hiprtc_sr | |||
bool hip_has_flags(const std::vector<std::string>& flags) | |||
{ | |||
hiprtc_program prog{" "}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is variable is not used, and should be removed. Also the other hip_has_flags
function should be removed.
Fixing Issue #3487 where compiling with incorrect hiprtc function results in error